1594524 - Debug overlays / profiler drawing is included in GPU measurements

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Markus Stange [:mstange]]

The presence of the profiler overlay is distorting the timings it displays.

We need to call end_frame before we start drawing the overlays.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1594524 - Move the call to gpu_profile.end_frame() up so that we don't measure debug overlays. r=gw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/455d161a3fa9
Move the call to gpu_profile.end_frame() up so that we don't measure debug overlays. r=gw

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 455d161a3fa9 (bug 1594524) for causing Wrench failure in adb wait-for-device shell cat /sys/class/power_supply/battery/input_suspend 2>/dev/null. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274911190&repo=autoland&lineNumber=1920

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=455d161a3fa92006c59f6411e3e01ccabb3c7074

Backout:
https://hg.mozilla.org/integration/autoland/rev/b53c2535ec7da21a0046cc362263b741613c387d

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mstange, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Markus Stange [:mstange]]

I don't know if the failure was caused by this patch. This particular job only ran on two out of ~10ish pushes while the patch was on autoland, so the data is a bit thin:

Original push: 1 red + 1 green
Some later push: 1 red
Backout push: 1 green

None of the other pushes in-between (1 2 3 4 5 6 7 8 9) got any Android 8.0 Pixel2 debug wrench runs.

The green retrigger is what makes me think this was spurious. I'm going to retrigger some more.

Comment 6

[Markus Stange [:mstange]]

Couldn't retrigger - Wrong version of actions.json, unable to continue. I'll make a try push.

Comment 7

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5650578b4a7e1bd388ba402299e1501b26238ee

Comment 8

[Markus Stange [:mstange]]

Three green wrench runs. I'm going to re-land.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02828d8e1d78
Move the call to gpu_profile.end_frame() up so that we don't measure debug overlays. r=gw

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/02828d8e1d78