1594581 - Remove old lightning-migration.xul overlay file

Status: RESOLVED FIXED

(Calendar :: General, task, P3)

Description

[Paul Morris [:pmorris]]

As part of removing overlays from Calendar, we should just remove the lightning-migration.xul overlay file which handles data migrations from a calendar extension that pre-dates Lightning (!). The comment describing what it's doing dates from 2008:

https://searchfox.org/comm-central/source/calendar/lightning/content/lightning-migration.xul#6

Other data migrations (more recent) are handled elsewhere.

Comment 1

[Paul Morris [:pmorris]]

Attachment: remove-lightning-migration-overlay-0.patch

Removes the overlay file.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9107062 [details] [diff] [review]
remove-lightning-migration-overlay-0.patch

Hm, there may be more to this (maybe more to remove if we're dropping this file?).  I need to take a closer look, so let's hold off on review for now.
https://searchfox.org/comm-central/source/calendar/base/content/dialogs/calendar-migration-dialog.js#214

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9107062 [details] [diff] [review]
remove-lightning-migration-overlay-0.patch

OK, I think removing just the overlay file is fine.  The `checkOldCal` function also covers Sunbird, beyond just the pre-lightning add-on, and there's no harm in keeping migration code if there's no reason to remove it (as with the overlay).  The migration routines are still called here (before the home calendar is set up): https://searchfox.org/comm-central/source/calendar/base/content/calendar-management.js#421

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9107062 [details] [diff] [review]
remove-lightning-migration-overlay-0.patch

Review of attachment 9107062 [details] [diff] [review]:
-----------------------------------------------------------------

I'd been meaning to kill this one :-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e912d62faefa
Remove lightning-migration.xul overlay file. r=darktrojan