Closed Bug 1594581 Opened 5 months ago Closed 5 months ago

Remove old lightning-migration.xul overlay file

Categories

(Calendar :: General, task, P3)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmorris, Assigned: pmorris)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of removing overlays from Calendar, we should just remove the lightning-migration.xul overlay file which handles data migrations from a calendar extension that pre-dates Lightning (!). The comment describing what it's doing dates from 2008:

https://searchfox.org/comm-central/source/calendar/lightning/content/lightning-migration.xul#6

Other data migrations (more recent) are handled elsewhere.

Blocks: 1493008, 1508119

Removes the overlay file.

Attachment #9107062 - Flags: review?(geoff)
Status: NEW → ASSIGNED
Comment on attachment 9107062 [details] [diff] [review]
remove-lightning-migration-overlay-0.patch

Hm, there may be more to this (maybe more to remove if we're dropping this file?).  I need to take a closer look, so let's hold off on review for now.
https://searchfox.org/comm-central/source/calendar/base/content/dialogs/calendar-migration-dialog.js#214
Attachment #9107062 - Flags: review?(geoff)
Comment on attachment 9107062 [details] [diff] [review]
remove-lightning-migration-overlay-0.patch

OK, I think removing just the overlay file is fine.  The `checkOldCal` function also covers Sunbird, beyond just the pre-lightning add-on, and there's no harm in keeping migration code if there's no reason to remove it (as with the overlay).  The migration routines are still called here (before the home calendar is set up): https://searchfox.org/comm-central/source/calendar/base/content/calendar-management.js#421
Attachment #9107062 - Flags: review?(geoff)
Comment on attachment 9107062 [details] [diff] [review]
remove-lightning-migration-overlay-0.patch

Review of attachment 9107062 [details] [diff] [review]:
-----------------------------------------------------------------

I'd been meaning to kill this one :-)
Attachment #9107062 - Flags: review?(geoff) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e912d62faefa
Remove lightning-migration.xul overlay file. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 72
You need to log in before you can comment on or make changes to this bug.