Closed Bug 1594595 Opened 2 years ago Closed 2 years ago

Enable PHC on early beta 72 builds

Categories

(Core :: Memory Allocator, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

We want to enable PHC on early beta builds in 72, in early December.

Some edited comments from Slack:

  • we need to figure out how to propagate EARLY_BETA_OR_EARLIER to the build script
  • it's an AC_SUBST, it's available in moz.build. Not in configure, though, because it's all in autoconf
  • we can "parse" the defines.sh file in python configure, and make it available in build/moz.configure/memory.configure.

glandium: Any suggestions on breaking this down further, and who should do it?

Flags: needinfo?(mh+mozilla)
Depends on: 1285401
Flags: needinfo?(mh+mozilla)
Depends on: 1597834
No longer depends on: 1285401

Nick, it looks like we're at the point where we should just unconditionally enable and let it ride the train. 2 weeks into the beta we can uplift a backout.

Flags: needinfo?(n.nethercote)
Flags: needinfo?(n.nethercote)
Summary: Enable PHC on early beta builds → Enable PHC on early beta 72 builds
Assignee: nobody → n.nethercote
Attachment #9111483 - Attachment description: Bug 1594595 - Enable PHC on early beta 72 builds. r=glandium → Bug 1594595 - Enable PHC on early beta 72 builds. r=erahm
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa3baf2116b1
Enable PHC on early beta 72 builds. r=erahm
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

I just discovered that this commit doesn't work. The not default_replace_malloc condition here succeeds, which disables PHC. So PHC hasn't been enabled on Beta 72, which explains why no new PHC crashes have come in.

Mike, what would be the right way to enable this on Beta? Remove the not default_replace_malloc condition? Something else?

Flags: needinfo?(mh+mozilla)

I guess you can remove/comment the entire condition. Another solution would be to restore the original code and put an explicit --enable-phc in the relevant mozconfigs.

Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.