1594595 - Enable PHC on early beta 72 builds

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Description

[Nicholas Nethercote [inactive]]

We want to enable PHC on early beta builds in 72, in early December.

Comment 1

[Nicholas Nethercote [inactive]]

Some edited comments from Slack:

• we need to figure out how to propagate EARLY_BETA_OR_EARLIER to the build script
• it's an AC_SUBST, it's available in moz.build. Not in configure, though, because it's all in autoconf
• we can "parse" the defines.sh file in python configure, and make it available in build/moz.configure/memory.configure.

glandium: Any suggestions on breaking this down further, and who should do it?

Comment 2

[Eric Rahm [:erahm]]

Nick, it looks like we're at the point where we should just unconditionally enable and let it ride the train. 2 weeks into the beta we can uplift a backout.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1594595 - Enable PHC on early beta 72 builds. r=erahm

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa3baf2116b1
Enable PHC on early beta 72 builds. r=erahm

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fa3baf2116b1

Comment 6

[Nicholas Nethercote [inactive]]

I just discovered that this commit doesn't work. The not default_replace_malloc condition here succeeds, which disables PHC. So PHC hasn't been enabled on Beta 72, which explains why no new PHC crashes have come in.

Mike, what would be the right way to enable this on Beta? Remove the not default_replace_malloc condition? Something else?

Comment 7

[Mike Hommey [:glandium]]

I guess you can remove/comment the entire condition. Another solution would be to restore the original code and put an explicit --enable-phc in the relevant mozconfigs.