Closed Bug 1594753 Opened 4 years ago Closed 4 years ago

8.32 - 11.36% kraken (linux64-shippable, macosx1014-64-shippable, windows10-64-shippable, windows10-64-shippable-qr, windows7-32-shippable) regression on push 78d02a12be591b6260f878e70fc8ba73d857e893 (Tue November 5 2019)

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 --- fixed

People

(Reporter: alexandrui, Assigned: cfallin)

References

(Regression)

Details

(4 keywords)

Attachments

(1 file)

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=78d02a12be591b6260f878e70fc8ba73d857e893

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

11% kraken windows7-32-shippable opt e10s stylo 1,019.08 -> 1,134.82
10% kraken windows7-32-shippable opt e10s stylo 1,021.51 -> 1,124.08
10% kraken windows10-64-shippable opt e10s stylo 944.56 -> 1,036.72
9% kraken linux64-shippable opt e10s stylo 927.24 -> 1,015.13
9% kraken windows10-64-shippable-qr opt e10s stylo 950.29 -> 1,037.22
8% kraken macosx1014-64-shippable opt e10s stylo 1,113.89 -> 1,206.62

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=23741

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/TestEngineering/Performance/Talos

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/TestEngineering/Performance/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/TestEngineering/Performance/Talos/RegressionBugsHandling

Flags: needinfo?(cfallin)
Component: Performance → JavaScript Engine
Product: Testing → Core
Version: Version 3 → unspecified

Sorry about this -- it was an unexpected interaction with a JS engine change. We had run tests but I didn't (yet) know about Kraken. We'll roll back and make sure the perf delta is gone before re-landing.

Flags: needinfo?(cfallin)

The change above caused an unexpected performance regression on Kraken,
in particular due to the way that the new parse-time approach to
allocating objects influenced the ObjectGroups of the created objects,
leading to overly-polymorphic ICs in a numeric-heavy benchmark
(stanford-crypto-aes).

We'll work on a fix, but in the meantime, we don't want to leave the
slowdown on m-c.

Attachment #9107256 - Attachment description: Bug 1594753: Rollback of change in Bug 1580246 (Remove object-literal singleton...). r=mgaudet → Bug 1594753: Backed out changeset 78d02a12be59. r=mgaudet
Priority: -- → P1
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3312cfcb08b
Backed out changeset 78d02a12be59. r=mgaudet
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → cfallin

Backout
== Change summary for alert #23756 (as of Fri, 08 Nov 2019 09:21:03 GMT) ==

Improvements:

10% kraken macosx1014-64-shippable opt e10s stylo 1,217.60 -> 1,095.32
9% kraken windows10-64-shippable-qr opt e10s stylo 1,043.86 -> 945.52
9% kraken linux64-shippable-qr opt e10s stylo 1,029.40 -> 940.72
8% kraken windows10-64-shippable opt e10s stylo 1,053.43 -> 966.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23756

Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: