Closed Bug 1594755 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 20150 - Use existing external resource for <use> while revalidating

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20150 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20150
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Use existing external resource for <use> while revalidating

When we load a previously cached resource for \<use> and it requires
revalidation - and an earlier \<use> that references the same resource
hasn't yet generated its shadow tree - we could end up failing to
generate a shadow tree for the the "first" \<use> since the resource
appears to be "invalid" while the revalidation is in progress. This
"first" \<use> would then not be invalidated when the revalidation
completes.

Consider the resource to be valid while revalidating if it has a
Document already - meaning it has previously finished loading and
successfully parsed a document. This means the "first" \<use> might end
up being stale until it's invalidated if the revalidation returned a
newer version of the resource - which is wrong but arguably better than
failing to display at all like was the case previously. (This should
also be consistent with how other types of resources are handled in
cases like this.)

Bug: 593261, 1021530
Change-Id: I9d68a1a60685757a990c2ec811c5ca53afc4fb25
Reviewed-on: https://chromium-review.googlesource.com/1903200
WPT-Export-Revision: 3f3c7dc2cfa86879113a701177760792b8674af6

Component: web-platform-tests → SVG
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f4d727a7564
[wpt PR 20150] - Use existing external resource for <use> while revalidating, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dbd303a7f27f
[wpt PR 20150] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.