Closed Bug 1594887 Opened 3 months ago Closed 3 months ago

Remove xpidl [array] use in nsIMsgFilterPlugin

Categories

(MailNews Core :: Backend, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: benc, Assigned: benc)

References

Details

Attachments

(3 files)

No description provided.
Assignee: nobody → benc
No longer blocks: 1562158
Blocks: 1551704
Attachment #9111775 - Flags: review?(mkmelin+mozilla)
Attachment #9111776 - Flags: review?(mkmelin+mozilla)
Attachment #9111777 - Flags: review?(mkmelin+mozilla)

Tedious stuff, but nothing too fancy in there, I think.
Unit tests look clean locally. Try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2a7fe3a50657cd5971be44626800780902892fee

Attachment #9111775 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Attachment #9111776 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9111777 [details] [diff] [review]
1594887-part-3-nsIJunkMailPlugin-1.patch

Review of attachment 9111777 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +2135,5 @@
>    nsTArray<uint32_t> antiIndices;
>    rv = traitService->GetEnabledAntiIndices(antiIndices);
>    NS_ENSURE_SUCCESS(rv, rv);
>  
> +  rv = aJunkMailPlugin->ClassifyTraitsInMessage(nsDependentCString(aURI),

I was going to ask if you're sure aURI isn't null. But it looks like this whole method (SpamFilterClassifyMessage) is dead code and should just be removed
Attachment #9111777 - Flags: review?(mkmelin+mozilla) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d361ca43bf11
Remove xpidl [array] use in nsIMsgTraitClassificationListener. r=mkmelin
https://hg.mozilla.org/comm-central/rev/86c11d411a01
Remove xpidl [array] use in nsIMsgTraitDetailListener. r=mkmelin
https://hg.mozilla.org/comm-central/rev/30ad6ed6ebb6
Remove xpidl [array] use in nsIJunkMailPlugin. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f2927c0ca076
Follow-up: Reformat. rs=reformat
You need to log in before you can comment on or make changes to this bug.