1594938 - Crash in [@ nsSHistory::Reload]

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-9a4e61c6-5792-40c5-ab3a-632580191107.

Seen while looking at nightly crash stats - crashes started in 20191107094905: https://bit.ly/36MvuBd. 15 crashes/3 installs on Windows and macOS so far.

Code was touched in Bug 1438272. ni on :peterv

Top 10 frames of crashing thread:

0 xul.dll nsresult nsSHistory::Reload docshell/shistory/nsSHistory.cpp:846
1 xul.dll mozilla::dom::ChildSHistory::Reload docshell/shistory/ChildSHistory.cpp:51
2 xul.dll static bool mozilla::dom::ChildSHistory_Binding::reload dom/bindings/ChildSHistoryBinding.cpp:191
3 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3218
4 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:548
5 xul.dll static bool Interpret js/src/vm/Interpreter.cpp:3110
6 xul.dll static bool js::RunScript js/src/vm/Interpreter.cpp:423
7 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:589
8 xul.dll JS::Call js/src/jsapi.cpp:2718
9 xul.dll mozilla::dom::MessageListener::ReceiveMessage dom/bindings/MessageManagerBinding.cpp:6864

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Hmm, null+offset crash I think

Comment 2

[Marcia Knous [:marcia]]

Forgot to add peterv in the ni. #10 crash overall on nightly and is happening consistently in each build.

Comment 3

[Peter Van der Beken [:peterv]]

I guess if the OnHistoryReload listener causes us to not navigate we shouldn't be calling LoadURI.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Bug 1594938 - Crash in [@ nsSHistory::Reload]. r?smaug!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8157c99955b1
Crash in [@ nsSHistory::Reload]. r=smaug

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8157c99955b1