Closed
Bug 1594964
Opened 4 years ago
Closed 4 years ago
Unify linting rules for test directories
Categories
(MailNews Core :: Testing Infrastructure, task)
MailNews Core
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 72.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
21.64 KB,
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
We've got lint configuration files all over the place. In this bug I aim to throw out a lot of them and have all the test directories configured from the main file.
Assignee | ||
Comment 1•4 years ago
|
||
I've moved the mailnews/mime/jsmime/test
to mailnews/mime/jsmime/test/unit
so that it fits the pattern and gets the same configuration as all the others. I've had to override the calendar configuration so technically there are now two config files but that's still an improvement.
Attachment #9107406 -
Flags: review?(paul)
Comment 2•4 years ago
|
||
Not really to do with Firefox Build System, so moving it across.
Component: Lint and Formatting → Testing Infrastructure
Product: Firefox Build System → MailNews Core
Assignee | ||
Comment 3•4 years ago
|
||
Oh, um, oops. Must've got that when I created it as a dependency.
Comment 4•4 years ago
|
||
Comment on attachment 9107406 [details] [diff] [review] 1594964-test-lint-config-1.diff Review of attachment 9107406 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #9107406 -
Flags: review?(paul) → review+
Assignee | ||
Updated•4 years ago
|
Keywords: checkin-needed-tb
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cacce68c2d9a
Unify linting rules for test directories. r=pmorris
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 72.0
You need to log in
before you can comment on or make changes to this bug.
Description
•