Closed Bug 1594999 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20170 - Plumb outside settings object for ServiceWorkerRegistration#update()

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20170 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20170
Details from upstream follow.

Kenichi Ishibashi <bashi@chromium.org> wrote:

Plumb outside settings object for ServiceWorkerRegistration#update()

This is similar to crrev.com/c/1861294 but for update(). Script
fetches for update check happen on the browser and are managed
by ServiceWorkerUpdateChecker so pass some information to
ServiceWorkerUpdateChecker too.

This CL has a behavioral change. The 'Referer' header of the request
triggered by update() in a document/service worker will be changed.
Before this CL it was the url of the top-level script but after this
CL it is document/service worker's url. This behavior is consistent
with the spec.

Bug: 937177
Change-Id: I57e9ce7c91a748ad549a49e4e46c7890dcca2903

Reviewed-on: https://chromium-review.googlesource.com/1905028
WPT-Export-Revision: a2deda1365368f8fb6e62bff71bd3353833568c8

PR 20170 applied with additional changes from upstream: 98f4cb23e0c4e16c821721601f1c94c837803ee8
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Component: DOM: Service Workers → web-platform-tests
Product: Core → Testing
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e73ca41b088
[wpt PR 20170] - Plumb outside settings object for ServiceWorkerRegistration#update(), a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/3e73ca41b088

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.