1595029 - Search text from the search bar in Customize menu is not centered

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: macOS_search.png

Affected versions

• 71.0b8 (20191107101713)
• 72.0a1 (20191107215315)

Affected platforms

• macOS 10.14
• macOS 10.10

Steps to reproduce

1. Open Firefox and go to Customize Menu.
2. Observe the Search item.

Expected result

• Centered text on the Search bar inside the Customize menu.

Actual result

• Search text inside Search bar is not centered.

Regression range

• Last good revision: a4bfd6e22c412a65d558d46c6a3f19da14a03a85
• First bad revision: 9ec431469e3777c3c9675e7699a38e3155ada5dd
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4bfd6e22c412a65d558d46c6a3f19da14a03a85&tochange=9ec431469e3777c3c9675e7699a38e3155ada5dd
• Potential regressor: bug 1534455

Additional Notes

• Attached a screenshot on Windows and macOS with the issue.
• Ubuntu is not affected.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: windows search.png

This is how it looks on Windows10 x64.

Comment 2

[Tim Nguyen :ntim]

The placeholder text used to be hidden within the customize mode using:

toolbarpaletteitem > toolbaritem > textbox > moz-input-box > html|*.textbox-input {
  visibility: hidden;
}

in textbox.css, but that rule stopped applying with bug 1534455 and bug 1513325 removed it.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1595029 - Hide searchbar placeholder text in customize mode. r=Gijs

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 9107567 [details]
Bug 1595029 - Hide searchbar placeholder text in customize mode. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: "Search" placeholder text is wrongly in searchbar in customize mode
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0, the placeholder text should be hidden like it was before.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward CSS fix
• String changes made/needed: none

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02b02d679df2
Hide searchbar placeholder text in customize mode. r=Gijs

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/02b02d679df2

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9107567 [details]
Bug 1595029 - Hide searchbar placeholder text in customize mode. r=Gijs

One line CSS fix for visual polish, looks safe for beta, uplift approved for 71 beta 9, thanks.

Comment 8

[Tim Nguyen :ntim]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4948445b6f5bfe0011444b5cfab31ca86efe33e

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello!
The issue is verified fixed with Firefox 72.0a1 (20191111215252) and Firefox 71.0b9 (20191111170815) on Windows 10x64, macOS 10.14 and Ubuntu 18.04. No text is shown on the "Search bar" item in Customize mode.