1595059 - drag contact to another address book fails NS_ERROR_STORAGE_CONSTRAINT: Component returned failure code: 0x80630003

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

NS_ERROR_STORAGE_CONSTRAINT: Component returned failure code: 0x80630003 (NS_ERROR_STORAGE_CONSTRAINT) [mozIStorageStatement.execute] AddrBookDirectory.jsm:745
dropCard resource:///modules/AddrBookDirectory.jsm:745
onDrop chrome://messenger/content/addressbook/abDragDrop.js:334
drop chrome://messenger/content/addressbook/abTrees.js:212

Comment 1

[Geoff Lankow (:darktrojan)]

This is basically saying that you already have the card you're copying. But it thinks that because it's replaced the card's unique identifier with "1".

Why did it do that? Because I misread a line of code that was unambiguous until Prettier came along and removed the brackets.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1595059-dropcard-newuid-1.diff

I don't think there's much worth doing about the mangled UID. No data's been lost, except that card now has a UID of 1.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9107768 [details] [diff] [review]
1595059-dropcard-newuid-1.diff

Review of attachment 9107768 [details] [diff] [review]:
-----------------------------------------------------------------

Why doesn't it have a UID in the first place? Seems we should just cancel the drop if that data was somehow lost

Comment 4

[Geoff Lankow (:darktrojan)]

It should always have a UID, but you never know. It could be from some weird new address book provider that doesn't automatically assign them. If needToCopyCard is true we assign a new UID so that it doesn't have the same one as the original card.

Comment 5

[Jorg K (CEST = GMT+2)]

Sure you can get beta approval, but how about getting review first?

Comment 6

[Magnus Melin [:mkmelin]]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

It should always have a UID, but you never know. It could be from some weird new address book provider that doesn't automatically assign them.

I think they do need to have an UID. We should require that.

Comment 7

[Geoff Lankow (:darktrojan)]

So what do you want me to actually do here?

Comment 8

[Geoff Lankow (:darktrojan)]

… bearing in mind that the change I'm proposing just puts the code back how it was before the regression I caused.

Comment 9

[Magnus Melin [:mkmelin]]

Maybe we just don't want to allow dragging if the card doesn't have an id to begin with (because something's wrong)? Bail out at https://searchfox.org/comm-central/rev/496170162015a8c4a4087c18479279b4ce3b2cbf/mailnews/addrbook/content/abDragDrop.js#90 ?

Wayne, how did you end up with the brokenness?

Comment 10

[Wayne Mery (:wsmwk)]

I don't know precisely. Best recollection - I had updated beta and my ABs were converted, then simply tried to drag a contact from Personal Address Book to another AB.

Comment 11

[Geoff Lankow (:darktrojan)]

The card does have a UID. The code replaced it with "1" because I screwed up. This patch undoes the screw-up.

Comment 12

[Magnus Melin [:mkmelin]]

What card are we talking about that has the UID=1? So just some temporary flux no end user will see?

Comment 13

[Geoff Lankow (:darktrojan)]

The card added to the destination database is given the UID 1. This error is caused at the next call to dropCard, which also assigns UID 1 to a card and tries to add it to the database.

Fortunately all this has caused is preventing the user moving cards from one address book to another, and no real damage.

Comment 14

[Magnus Melin [:mkmelin]]

I see.
Can we make it newCard._uid = needToCopyCard ? newUID() : card.UID;

• don't allow dragging cards withough UIDs?

Comment 15

[Geoff Lankow (:darktrojan)]

Attachment: 1595059-dropcard-newuid-2.diff

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 9110427 [details] [diff] [review]
1595059-dropcard-newuid-2.diff

Review of attachment 9110427 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, r=mkmelin
The commit message could need an update

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aec0ee0dc9f8
Prevent copying an address book card without a UID, and fix copying cards from one book to another; r=mkmelin DONTBUILD

Comment 18

[Geoff Lankow (:darktrojan)]

71 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/64d30069741e189b6ee137d566ad5dcfa2c4729a