1595100 - [wpt-sync] Sync PR 20178 - [PeerConnection] Update addIceCandidate to use the Operations Chain.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 20178 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20178
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

[PeerConnection] Update addIceCandidate to use the Operations Chain.

Invoke the callback-based version of AddIceCandidate() recently added in
third_party/webrtc.

This CL also...

• Adds WPT test coverage for two separate but related issues relating to
  the timing between SLD and addIceCandidate which may cause edge-case
  race conditions when exchanging ICE candidates. See referenced bugs.
• Remove old AddIceCandidate code path.

Bug: chromium:1019222, chromium:1019232
Change-Id: I11d013487325b14739f99617c1d2063a06743524
Reviewed-on: https://chromium-review.googlesource.com/1906368
WPT-Export-Revision: fd21e5d73a638a5501eb425c800840ffa609b7a9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9524bc63eaae1ef9b7c8eb85bc62380f4f56786c

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ec10f2f98ba
[wpt PR 20178] - [PeerConnection] Update addIceCandidate to use the Operations Chain., a=testonly
https://hg.mozilla.org/integration/autoland/rev/bb0197ea9815
[wpt PR 20178] - Update wpt metadata, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 2 subtests

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

New tests that's don't pass

/webrtc/RTCPeerConnection-addIceCandidate-timing.https.html
addIceCandidate and setLocalDescription are resolved in the correct order, as defined by the operations chain specification: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
addIceCandidate is not resolved first if 2x setLocalDescription operations are pending: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9ec10f2f98ba
https://hg.mozilla.org/mozilla-central/rev/bb0197ea9815