Closed Bug 1595100 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 20178 - [PeerConnection] Update addIceCandidate to use the Operations Chain.

Categories

(Core :: WebRTC, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20178 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20178
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

[PeerConnection] Update addIceCandidate to use the Operations Chain.

Invoke the callback-based version of AddIceCandidate() recently added in
third_party/webrtc.

This CL also...

  • Adds WPT test coverage for two separate but related issues relating to
    the timing between SLD and addIceCandidate which may cause edge-case
    race conditions when exchanging ICE candidates. See referenced bugs.
  • Remove old AddIceCandidate code path.

Bug: chromium:1019222, chromium:1019232
Change-Id: I11d013487325b14739f99617c1d2063a06743524
Reviewed-on: https://chromium-review.googlesource.com/1906368
WPT-Export-Revision: fd21e5d73a638a5501eb425c800840ffa609b7a9

Component: web-platform-tests → WebRTC
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ec10f2f98ba
[wpt PR 20178] - [PeerConnection] Update addIceCandidate to use the Operations Chain., a=testonly
https://hg.mozilla.org/integration/autoland/rev/bb0197ea9815
[wpt PR 20178] - Update wpt metadata, a=testonly

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 2 subtests

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

New tests that's don't pass

/webrtc/RTCPeerConnection-addIceCandidate-timing.https.html
addIceCandidate and setLocalDescription are resolved in the correct order, as defined by the operations chain specification: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
addIceCandidate is not resolved first if 2x setLocalDescription operations are pending: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.