Closed
Bug 1595245
Opened 5 years ago
Closed 5 years ago
Uncaught ADBTimeoutErrors raised in mozharness shell_output do not retry
Categories
(Testing :: General, defect, P1)
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Mozharness log parsers scan logs for "retry" patterns and exit with TBPL_RETRY if found. That works great when a test harness fails with one of those patterns, like ADBTimeoutError; but if the mozharness script explicitly exits with fatal(another code), none of that matters.
For instance:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274958427&repo=autoland&lineNumber=1111
Assignee | ||
Updated•5 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•5 years ago
|
||
A review of the recent failures in bug 1500266 found that all of the failures of this type - ADB*Error raised in the mozharness script - originated in the mozharness shell_output().
Assignee | ||
Comment 2•5 years ago
|
||
Most mozdevice access in mozharness was already encapsulated in try blocks, with only the
shell_output() case neglected, consistent with the observed intermittent failures.
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09cc380c54d9 Translate remaining uncaught mozharness ADBErrors into task retries; r=bc
Assignee | ||
Updated•5 years ago
|
Summary: Uncaught ADB*Error exceptions raised in mozharness do not retry → Uncaught ADBTimeoutErrors raised in mozharness shell_output do not retry
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•