1595259 - basic/hypot-approx.js triggers left shift of a negative value in e_hypot.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jeff Walden [:Waldo]]

Compiling with shift-overflow sanitizing, this test triggers a left shift by -600. Haven't investigated how yet, just saw it in scrollby when running tests locally.

Comment 1

[Jeff Walden [:Waldo]]

Er, whoops -- -600 is the value being shifted, not the shift amount.

Comment 2

[Jeff Walden [:Waldo]]

I filed an upstream PR that'll fix this, once they accept it and we do a fresh import.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 4

[Jan de Mooij [:jandem]]

arai, is it easy to update our copy? Waldo's fix landed a few years ago in the upstream code, as far as I can tell.

Comment 5

[Tooru Fujisawa [:arai]]

I'll look into this tomorrow.

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1595259 - Part 1: Use python3 in modules/fdlibm/update.sh. r=mgaudet!

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1595259 - Part 2: Update patches. r=mgaudet!

Depends on D154077

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1595259 - Part 3: Update fdlibm to 369ea0520a3061c07400d7cd32172efb6af39815. r=mgaudet!

Depends on D154078

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de1cc55fdbb
Part 1: Use python3 in modules/fdlibm/update.sh. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/313d7588e499
Part 2: Update patches. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b9f69ae62997
Part 3: Update fdlibm to 369ea0520a3061c07400d7cd32172efb6af39815. r=mgaudet

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/9a22844cc6c0b2eb8d2f0725b4dfa4dfc3cf1bcf

Push with failures

Failure log

/builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -m32 -Fos_cos.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/modules/fdlibm/src -I/builds/worker/workspace/obj-build/modules/fdlibm/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -W3 -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wno-ambiguous-reversed-operator -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-enum-float-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wno-error=deprecated-volatile -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -arch:SSE2 -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -Wno-sign-compare -wd4146 -wd4305 -wd4723 -wd4756 -fno-strict-aliasing -Xclang -ffp-contract=off  -Xclang -MP -Xclang -dependency-file -Xclang .deps/s_cos.obj.pp -Xclang -MT -Xclang s_cos.obj   /builds/worker/checkouts/gecko/modules/fdlibm/src/s_cos.cpp
[task 2022-08-09T17:46:42.795Z] 17:46:42     INFO -  In file included from /builds/worker/checkouts/gecko/modules/fdlibm/src/s_cos.cpp:51:
[task 2022-08-09T17:46:42.795Z] 17:46:42     INFO -  /builds/worker/checkouts/gecko/modules/fdlibm/src/e_rem_pio2.cpp(130,11): error: unknown type name '__float_t'; did you mean 'float_t'?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4db16ebd4256
Part 1: Use python3 in modules/fdlibm/update.sh. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/93b5b7fc9b5f
Part 2: Update patches. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1995acac9f11
Part 3: Update fdlibm to 369ea0520a3061c07400d7cd32172efb6af39815. r=mgaudet

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4db16ebd4256
https://hg.mozilla.org/mozilla-central/rev/93b5b7fc9b5f
https://hg.mozilla.org/mozilla-central/rev/1995acac9f11