1595260 - Too-large shift amount possible at OrderedHashTable.h:623, e.g. with basic/bug1236476.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jeff Walden [:Waldo]]

For example,

[jwalden@find-waldo-now src]$ python jit-test/jit_test.py dbg/js/src/js basic/bug1236476.js
/home/jwalden/moz/after/js/src/ds/OrderedHashTable.h:623:14: runtime error: shift exponent 32 is too large for 32-bit type 'int'

This is a 1 << (...) expression that's the return value from a function that returns uint32_t. Simply changing the 1 to be uint32_t isn't an adequate fix, interestingly, if the exponent-of-32 is accurate. So this could be more interesting than these bad-shift-amount sorts of bugs tend to be...

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1595260 - Allow OrderedHash{Map,Set} to be safely destroyed in cases where it was never successfully initialized. r=sfink

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f18d343c7f9d
Allow OrderedHash{Map,Set} to be safely destroyed in cases where it was never successfully initialized.  r=sfink

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f18d343c7f9d