1595319 - enable eslint for mail/extensions/openpgp

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert (:KaiE:)]

enable eslint for mail/extensions/openpgp

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1595319 - enable eslint for mail/extensions/openpgp. r?mkmelin

Comment 2

[Kai Engert (:KaiE:)]

This patch was made on top of the patches from bug 1616575 and bug 1616558, so those need to go in first.

Also, I need the eslintrc fixes from bug 1616608 to land first, because this patch has a function with big complexity.

Finally, I have one small TODO left, in addition to the attached huge patch, to avoid one more eslint warning. I'll provide a separate, incremental patch for that.

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Bug 1595319 - Use new syntax for ChromeUtils.import. r=mkmelin

Comment 4

[Kai Engert (:KaiE:)]

Attachment: Bug 1595319 - Fix a remaining eslint issue, changing indent. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e3303808c596
enable eslint for mail/extensions/openpgp. r=mkmelin
https://hg.mozilla.org/comm-central/rev/507970329f68
Use new syntax for ChromeUtils.import. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6c75755a02eb
Fix a remaining eslint issue, changing indent. r=mkmelin DONTBUILD

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6a1d2bed20be
Follow-up to fix eslint bustage. rs=bustage-fix DONTBUILD

Comment 7

[Kai Engert (:KaiE:)]

Attachment: Bug 1595319 - const/var import fixes, and fix signing. r=PatrickBrunschwig

Comment 8

[Kai Engert (:KaiE:)]

Attached another patch to fix:

• a few places where I used "const ... import", which is failing
• signing. With this change, sending signed or signed&encrypted works

Comment 9

[Kai Engert (:KaiE:)]

The enigmail code used "test signing" to find out what hash algorithm gnupg used for a given signer key. I disabled that, and hardcoded to use SHA256 for now. Added a comment that this needs to be coordinated with rnp.jsm which also hardcodes SHA256 currently.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/423c84a5eae7
const/var import fixes, and fix signing. r=PatrickBrunschwig DONTBUILD