Closed Bug 1595408 Opened 5 months ago Closed 5 months ago

Sidebars on macOS are no longer vibrant

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: mstange, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I broke this in bug 1592739 and forgot to file a bug earlier.

On macOS, the sidebar in the Thunderbird window and the Thunderbird address book window are no longer vibrant - that means they now have an opaque background color, rather than being transparent with a glass-like appearance (showing blurred content from behind the window).

To fix this, all background-colors from elements behind the sidebar elements need to be removed (or moved elsewhere).

  • In the main window, #messengerBox is an ancestor of #folderTree and has background-color: -moz-Dialog. This background color needs to be removed.
  • In the address book window, it's #abContent which has background-color: -moz-Dialog. This background-color should be moved to #abResultsBox, #CardViewOuterBox or #CardViewBox.
Assignee: nobody → richard.marti

This fixes the vibrancy. Like FX now when a simple LW-theme is active no vibrancy is used. This is for me a regression. The Mac chat tab needed some more tweaks.

Alessandro, with a simple LW-theme I gave the Mac sidebars the -moz-OddTreeRow. Is this okay?

Attachment #9107926 - Flags: review?(alessandro)
Comment on attachment 9107926 [details] [diff] [review]
1595408-make-trees-vibrant.patch

Review of attachment 9107926 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.
r=aleca
Attachment #9107926 - Flags: review?(alessandro) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/aeb3be1b2053
Remove the background color from #messengerBox and #abContent under macOS to make trees vibrant again. r=aleca

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.