1595413 - Minimum width in Debugger's side-panel breaks resizing

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P1)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

What were you doing?

1. Switch Debugger to vertical layout
2. Resize Breakpoints panel

What happened?

Content resizes past min-width of the panel.

Comment 1

[:Harald Kirschner :digitarald]

Sources sidepanel is also affected by this, but the effect isn't visual jus that resizing smaller than 250px causes resizing to stop working.

[Tracking Requested - why for this release]:
Broken panel resizing in Debugger.

Comment 2

[Julien Cristau [:jcristau]]

David is this something you can look at fixing before 71 ships?

Comment 3

[David Walsh :davidwalsh]

Attachment: Bug 1595413 - Revert debugger min-width to fix resizing r=jlast

Comment 4

[David Walsh :davidwalsh]

I sent a patch to Jason to revert my original change.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Json, is there an owner for this regression? I see a patch attached to this bug that has been ready for landing since last week, can it land and be uplifted to beta? Thanks

Comment 6

[Jason Laster [:jlast]]

Pascal, this is ready to be uplifted.

Comment 7

[Julien Cristau [:jcristau]]

Shouldn't the patch land on trunk first?

Comment 8

[Jason Laster [:jlast]]

Yes, sorry about that. I'll land it now

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ebe15b52932
Revert debugger min-width to fix resizing r=jlast

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5ebe15b52932

Comment 11

[:Harald Kirschner :digitarald]

Comment on attachment 9108397 [details]
Bug 1595413 - Revert debugger min-width to fix resizing r=jlast

Beta/Release Uplift Approval Request

• User impact if declined: Sidebars will be too wide in the DevTools' debugger and break badly when resizing.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Resize debugger sidebars in right-docked mode.
  Sidebars should just resize and not get stuck.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Reverts a minor CSS change.
• String changes made/needed:

Comment 12

[Cristian Fogel [:cfogel]]

Confirmed issue with 72.0a1 (2019-11-10) on Windows 10.
Fix verified with 72.0a1 (2019-11-18) on Windows 10, macOS 10.13, Ubuntu 18.04.

Comment 13

[Julien Cristau [:jcristau]]

Thanks David, Jason and Harald!

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9108397 [details]
Bug 1595413 - Revert debugger min-width to fix resizing r=jlast

P1, low risk CSS fix, verified in Nightly, uplift approved for 71 beta 12, thanks.

Comment 15

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0fe05870beb

Comment 16

[Cristian Fogel [:cfogel]]

Verified with 71.0b12 as well.