Closed Bug 1595415 Opened 3 months ago Closed 3 months ago

Remove the RTL hack in aboutDialog.css for displaying the version

Categories

(Firefox :: Menus, enhancement)

enhancement
Not set

Tracking

()

VERIFIED FIXED
Firefox 72
Tracking Status
firefox72 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

References

Details

(Keywords: rtl)

Attachments

(1 file)

In bug 682741 this may have been necessary, but since then, the version section now also includes the bitness and the "What's New" label (which are localizable), so there's no point in force-LTRing it anymore.

Because the "about" window has branding, we should ideally verify the appearance of the version number on all channels (Nightly, Beta, Developer Edition, Release) when this patch rides the trains. Testing LTR locales is required and RTL is advised, but it should be enough to use just one platform for each channel.

Flags: qe-verify+

Arash, heads up:
After this bug will be fixed, you may want to change the translations here:
https://pontoon.mozilla.org/fa/firefox/browser/browser/aboutDialog.ftl/?string=194969
https://pontoon.mozilla.org/fa/firefox/browser/browser/aboutDialog.ftl/?string=194971

My recommendation is to do, for the first one:

  • Translate the -bit part.

And for the second one:

  • Add RLM just before the ({ $isodate }) part, and
  • Translate the -bit part (or, if you prefer to leave it as-is, add LRM just before the { $bits } part).

You can use the following tool to verify you've entered the RLM/LRM characters correctly:
https://tomer.github.io/pilcrow/

Flags: needinfo?(mousavi.arash)
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5c6ce26727b
Remove the RTL hack in aboutDialog.css for displaying the version r=paolo

Thanks Itiel for the heads up! Fixed them.

Flags: needinfo?(mousavi.arash)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Verified - fixed on latest Nightly 72.0a1 (Build id: 20191119043902) on Windows 10, Ubuntu 18.04 and Mac OS 10.14 using ar and he builds.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.