Closed Bug 1595424 Opened 3 months ago Closed 2 months ago

Remove openTopWin function from SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey2.69
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg, NeedInfo)

References

Details

Attachments

(3 files)

openTopWin is basically unused after bug 1589189 and can be removed. For 2.53 we should remove all internal callers and for 2.57 and up also remove the function.

disallowInheritPrincipal does currently nothing. A follow-up needs to port Bug 674161 and friends. Not sure if it should be taken out here?

Attachment #9107762 - Flags: review?(iann_bugzilla)
Attachment #9107762 - Flags: approval-comm-release?
Attachment #9107762 - Flags: approval-comm-esr60?

Replace the calls in the debugQA extension.

Attachment #9107763 - Flags: review?(iann_bugzilla)
Attachment #9107763 - Flags: approval-comm-release?
Attachment #9107763 - Flags: approval-comm-esr60?

Remove the function only for 2.57 and up. It might be used by extensions and we don't want to break them in 2.53.

Attachment #9107764 - Flags: review?(iann_bugzilla)
Attachment #9107764 - Flags: approval-comm-esr60?
Blocks: 1595598
Comment on attachment 9107762 [details] [diff] [review]
1595424-1-killtopwin.patch

>+++ b/suite/base/content/nsContextMenu.js
>+    urlSecurityCheck(gContextMenuContentData.docLocation,
>+                     this.target.nodePrincipal,
With Bug 1589189 applied, this should probably be: this.principal

r/a=me with that addressed.
Attachment #9107762 - Flags: review?(iann_bugzilla)
Attachment #9107762 - Flags: review+
Attachment #9107762 - Flags: approval-comm-release?
Attachment #9107762 - Flags: approval-comm-release+
Attachment #9107762 - Flags: approval-comm-esr60?
Attachment #9107762 - Flags: approval-comm-esr60+
Comment on attachment 9107763 [details] [diff] [review]
1595424-2-killtopwindebugqa.patch

[Triage Comment]
r/a=me
Attachment #9107763 - Flags: review?(iann_bugzilla)
Attachment #9107763 - Flags: review+
Attachment #9107763 - Flags: approval-comm-release?
Attachment #9107763 - Flags: approval-comm-release+
Attachment #9107763 - Flags: approval-comm-esr60?
Attachment #9107763 - Flags: approval-comm-esr60+
Comment on attachment 9107764 [details] [diff] [review]
1595424-3-removetopwin.patch

r/a=me
Attachment #9107764 - Flags: review?(iann_bugzilla)
Attachment #9107764 - Flags: review+
Attachment #9107764 - Flags: approval-comm-esr60?
Attachment #9107764 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b3dfc1ed6f8e
Replace remaining openTopWin calls in SeaMonkey. r=IanN
https://hg.mozilla.org/comm-central/rev/122d65278cfe
Replace openTopWin calls in debugQA. r=IanN
https://hg.mozilla.org/comm-central/rev/79b9ad599631
Remove unused openTopWin function. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED

https://hg.mozilla.org/releases/comm-esr60/rev/e0970057c304ce9c645f1107cb224c297202cd98
Replace remaining openTopWin calls in SeaMonkey. r=IanN a=IanN CLOSED TREE
https://hg.mozilla.org/releases/comm-esr60/rev/82d3335dc616590cf8a2802c190f03923ac9dd8b
Replace openTopWin calls in debugQA. r=IanN a=IanN CLOSED TREE
https://hg.mozilla.org/releases/comm-esr60/rev/6e271c9fc6b49bc46d1bb217d03a088ac60c085f
Remove unused openTopWin function. r=IanN a=IanN CLOSED TREE

NI for possible follow-up wrt disallowInheritPrincipal

Flags: needinfo?(frgrahl)
Target Milestone: --- → seamonkey2.69
You need to log in before you can comment on or make changes to this bug.