1595424 - Remove openTopWin function from SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

openTopWin is basically unused after bug 1589189 and can be removed. For 2.53 we should remove all internal callers and for 2.57 and up also remove the function.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1595424-1-killtopwin.patch

disallowInheritPrincipal does currently nothing. A follow-up needs to port Bug 674161 and friends. Not sure if it should be taken out here?

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1595424-2-killtopwindebugqa.patch

Replace the calls in the debugQA extension.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1595424-3-removetopwin.patch

Remove the function only for 2.57 and up. It might be used by extensions and we don't want to break them in 2.53.

Comment 4

[Ian Neal]

Comment on attachment 9107762 [details] [diff] [review]
1595424-1-killtopwin.patch

>+++ b/suite/base/content/nsContextMenu.js
>+    urlSecurityCheck(gContextMenuContentData.docLocation,
>+                     this.target.nodePrincipal,
With Bug 1589189 applied, this should probably be: this.principal

r/a=me with that addressed.

Comment 5

[Ian Neal]

Comment on attachment 9107763 [details] [diff] [review]
1595424-2-killtopwindebugqa.patch

[Triage Comment]
r/a=me

Comment 6

[Ian Neal]

Comment on attachment 9107764 [details] [diff] [review]
1595424-3-removetopwin.patch

r/a=me

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b3dfc1ed6f8e
Replace remaining openTopWin calls in SeaMonkey. r=IanN
https://hg.mozilla.org/comm-central/rev/122d65278cfe
Replace openTopWin calls in debugQA. r=IanN
https://hg.mozilla.org/comm-central/rev/79b9ad599631
Remove unused openTopWin function. r=IanN

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/e0970057c304ce9c645f1107cb224c297202cd98
Replace remaining openTopWin calls in SeaMonkey. r=IanN a=IanN CLOSED TREE
https://hg.mozilla.org/releases/comm-esr60/rev/82d3335dc616590cf8a2802c190f03923ac9dd8b
Replace openTopWin calls in debugQA. r=IanN a=IanN CLOSED TREE
https://hg.mozilla.org/releases/comm-esr60/rev/6e271c9fc6b49bc46d1bb217d03a088ac60c085f
Remove unused openTopWin function. r=IanN a=IanN CLOSED TREE

NI for possible follow-up wrt disallowInheritPrincipal

Comment 9

[Frank-Rainer Grahl (:frg)]

Target 2.53.1 (only part 1 and 2 not the removal)
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/09b00c8ea076100490f38dd7be846b748355360d
Replace remaining openTopWin calls in SeaMonkey. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/85a77d5032dbf22f8729b7d22872e0be981bb931
Replace openTopWin calls in debugQA. r=IanN a=IanN

Comment 10

[Frank-Rainer Grahl (:frg)]

NI for possible follow-up wrt disallowInheritPrincipal accidently removed.