1595433 - bug1027510.js test fails with -0.5

Status: NEW

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Deian Stefan]

Attachment: 0001-Add-small-fractions-to-Math.ceil-bug1027510-test.patch

https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/ion/bug1027510.js#4-14 is incorrect for negative numbers greater than -1.

Comment 3

[Nicolas B. Pierron [:nbp]]

My understanding, as the attached patch indicates, is that this is only a test case issue.

Comment 4

[Steven DeTar [:sdetar]]

Nicolas, what are the next steps in resolving this bug if necessary. I am moving to P2 for now.

Comment 5

[Nicolas B. Pierron [:nbp]]

(In reply to Nicolas B. Pierron [:nbp] from comment #3)

My understanding, as the attached patch indicates, is that this is only a test case issue.

Patching test cases to match the correct function behavior is nice, but not mandatory, as we certainly have other hard-coded test cases to check for -0.5.

I will add that the current patch is probably not the approach to be followed, as the likelyhood on ceil being implemented as floor or sharing some code with it is high, in which case this test case would become a no-op, and no longer catch any issues.

Comment 6

[Deian Stefan]

The ceil bug seems to have been around for ~5 years, but totally deferring to you