1595483 - Remove visited-status-resolution notification, or make it test-only.

Status: RESOLVED FIXED

(Toolkit :: Places, task, P2)

Comment 1

[Marco Bonardo [:mak]]

We send this notification every time we resolve visited status for a link, it sounds like it would be a small perf win due to reduced work and notifications traffic.

Comment 2

[Marco Bonardo [:mak]]

Can we just use xpc::IsInAutomation() here?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Huh, I don't know why I never acted on this, likely forgot. Seems trivial to remove.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1595483 - Remove visited-status-resolution usage from browser_bug461710.js. r=mak

For those subtests we're already waiting for the color elsewhere, see
below.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1595483 - Remove visited-status-resolution waiting from bug293235_window.xhtml. r=mak

This is only useful to potentially catch the case where we incorrectly
paint a non-visited link as visited. That's something covered by all the
visited reftests extensively, and can't cause the rest of the test to
race, so it seems removable.

Depends on D97774

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1595483 - Remove visited-status-resolution notification. r=mak

No consumers left.

Depends on D97775

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1595483 - Remove visited-status-resolution in test_IHistory. r=mak

This is testing just that the observer is notified. But we're about to
remove it so... :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb28279f16b3
Remove visited-status-resolution in test_IHistory. r=mak

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bb28279f16b3

Comment 10

[Marco Bonardo [:mak]]

it looks like only the last patch landed?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Yup yup, I was lazy so landed first patch and planned to land the rest right after, but autoland was closed so... :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeb83660b104
Remove visited-status-resolution usage from browser_bug461710.js. r=mak
https://hg.mozilla.org/integration/autoland/rev/266a840ae45e
Remove visited-status-resolution waiting from bug293235_window.xhtml. r=mak
https://hg.mozilla.org/integration/autoland/rev/91c7a52f6aa4
Remove visited-status-resolution notification. r=mak

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/eeb83660b104
https://hg.mozilla.org/mozilla-central/rev/266a840ae45e
https://hg.mozilla.org/mozilla-central/rev/91c7a52f6aa4