1595487 - Configuration.packageName in Kotlin isn't used anywhere

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P3)

Description

[Michael Droettboom [:mdroettboom]]

The packageName configuration parameter is stored but not used anywhere. The packageName itself is hardcoded to be pulled from applicationContext.packageName in Glean.kt

We should decide whether providing the a way for the user to override the packageName is desirable, and if so, implement it as an override of applicationContext.packageName.

Comment 1

[Michael Droettboom [:mdroettboom]]

I'd be in favor of removing this and only putting it back in if we are aware of a use case. Right now, it's there, but has no effect, which isn't good...

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Michael Droettboom [:mdroettboom] from comment #1)

I'd be in favor of removing this and only putting it back in if we are aware of a use case. Right now, it's there, but has no effect, which isn't good...

You're right, this is not required as of now. Would it become so due to our ping submission architecture changes? If we need to build the submission URL in Rust, then we might need to know that.

Comment 3

[Michael Droettboom [:mdroettboom]]

This seems to have been fixed in the meantime. It exists in FfiConfiguration (so we can pass it to Rust), but not in the constructor of Configuration. So I'm calling this FIXED.