1595637 - Remove nsBaseChannel inheritance from DocumentChannelChild

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Jean-Yves Avenard [:jya]]

DocumentChannelChild inherits from nsBaseChannel (nsIChannel/nsIRequest) and because of it we end up doing a lot of things that serve no purpose in the context of the DocumentChannel.

Matt is also working on having the ability to start the DocumentChannelParent directly from a parent load.

This task will help getting the above done.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P1. Don't have DocumentChannelChild inherit from nsBaseChannel.

This expose that some methods aren't doing anything. We will address those in a follow-up change.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P2. Remove nsIIdentChannel from nsBaseChannel. r?mayhemer

It was only needed when used with DocumentChannelChild.

Depends on D52783

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P3. Only set contentType, contentDisposition and originalURI in the parent.

They don't need to be set on the DocumentChannelChild as they are never read.

Depends on D52784

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P4. Assert that DCC non-functional methods are never called.

Depends on D52785

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P6. Remove depency on ChannelEventQueue and NeckoTargetHolder from DocumentChannelChild. r?mayhemer

There was no need for the ChannelEventQueue and GetNeckoTarget() was always retuning the main thread anyway.

Comment 6

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P5. Remove Suspend/Resume methods from PDocumentChannel. r?mattwoodrow

They are no longer used.

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1595637 - P0. Remove use of NS_IF_ADDREF macro. r?mayhemer

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68a387538d04
P1. Don't have DocumentChannelChild inherit from nsBaseChannel. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/b1ee11c554be
P2. Remove nsIIdentChannel from nsBaseChannel. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/12366029e685
P3. Only set contentType, contentDisposition and originalURI in the parent. r=kmag,mayhemer
https://hg.mozilla.org/integration/autoland/rev/8e5a13009c6e
P4. Assert that DCC non-functional methods are never called. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/af11c7f18fb0
P5. Remove Suspend/Resume methods from PDocumentChannel. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/919240f3ee34
P6. Remove depency on ChannelEventQueue and NeckoTargetHolder from DocumentChannelChild. r=mayhemer

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d964fa16f33
P0. Remove use of NS_IF_ADDREF macro. r=mayhemer

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/68a387538d04
https://hg.mozilla.org/mozilla-central/rev/b1ee11c554be
https://hg.mozilla.org/mozilla-central/rev/12366029e685
https://hg.mozilla.org/mozilla-central/rev/8e5a13009c6e
https://hg.mozilla.org/mozilla-central/rev/af11c7f18fb0
https://hg.mozilla.org/mozilla-central/rev/919240f3ee34
https://hg.mozilla.org/mozilla-central/rev/1d964fa16f33