1595659 - Some One-Click Search Engines still can see in newtab search box after uncheck in preference

Status: RESOLVED DUPLICATE of bug 1403461

(Firefox :: Search, defect, P5)

Description

[yxu]

Attachment: One-Click Search Engines in newtab

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0
STR:
I am not sure if this issue is related to localization. I only tested it in the Simplified Chinese installation package.

1. Download the Simplified Chinese version of Firefox and open it with a new profile.
2. Set the default search engine to google in the preferences and uncheck all search engines except duckduckgo in the One-Click Search Engines list below (note that it is not removed).
3. Create a new tab, enter any character in the search box, you will see "Baidu", "Amazon", "Wikipedia" three search engines still show.

One-Click Search Engines in other locations will not display after unchecking, such as the address bar, search box, and the question only appears on the new tab. What I can think of in common is all these three search engines are named in Chinese?

Comment 1

[Mark Banner (:standard8)]

As you indicate those engine names are named in Chinese. From a quick glance at the code, we're reading the hidden-one-offs preference as ASCII rather than utf-8. Obviously then that's not setting the right flags to hide them.

I'd take a patch with a test (this one could probably be extended), but realistically, this is low priority, as it is likely a little-used UI, there's no significant user impact at not being able to hide those. At some stage, we might also be replacing it with the hand-off to the address bar, as can be seen on the latest nightly.

Comment 2

[Mark Banner (:standard8)]

This was fixed in bug 1403461.