Closed Bug 1595678 Opened 1 year ago Closed 1 year ago

Intermittent TV browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js | true == false - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_is...

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Status
firefox72 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: dluca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=275734146&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/R8r-LzulSc2dB_PVpjqGrQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/R8r-LzulSc2dB_PVpjqGrQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


INFO - TEST-START | browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js
[task 2019-11-12T03:32:53.842Z] 03:32:53     INFO - GECKO(1175) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpEqHa09.mozrunner/runtests_leaks_tab_pid1440.log
[task 2019-11-12T03:32:53.858Z] 03:32:53     INFO - GECKO(1175) | 1573529573851	addons.webextension.<unknown>	WARN	Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-12T03:32:53.878Z] 03:32:53     INFO - GECKO(1175) | [Child 1440, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-11-12T03:32:53.907Z] 03:32:53     INFO - GECKO(1175) | [Parent 1175, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-11-12T03:32:53.908Z] 03:32:53     INFO - GECKO(1175) | ++DOCSHELL 0x7f522892a000 == 6 [pid = 1230] [id = {2582ad5f-5aa7-42e6-87e4-f3f1e295fba4}]
[task 2019-11-12T03:32:53.908Z] 03:32:53     INFO - GECKO(1175) | ++DOMWINDOW == 30 (0x7f522782e3e0) [pid = 1230] [serial = 37] [outer = (nil)]
[task 2019-11-12T03:32:53.908Z] 03:32:53     INFO - GECKO(1175) | ++DOMWINDOW == 31 (0x7f5227881000) [pid = 1230] [serial = 38] [outer = 0x7f522782e3e0]
[task 2019-11-12T03:32:53.935Z] 03:32:53     INFO - GECKO(1175) | [Child 1230, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2700
[task 2019-11-12T03:32:53.955Z] 03:32:53     INFO - GECKO(1175) | ++DOMWINDOW == 32 (0x7f5228968000) [pid = 1230] [serial = 39] [outer = 0x7f522782e3e0]
[task 2019-11-12T03:32:54.033Z] 03:32:54     INFO - TEST-INFO | started process screentopng
[task 2019-11-12T03:32:54.484Z] 03:32:54     INFO - TEST-INFO | screentopng: exit 0
[task 2019-11-12T03:32:54.485Z] 03:32:54     INFO - Buffered messages logged at 03:32:53
[task 2019-11-12T03:32:54.486Z] 03:32:54     INFO - Entering test bound loadSource
[task 2019-11-12T03:32:54.486Z] 03:32:54     INFO - Leaving test bound loadSource
[task 2019-11-12T03:32:54.487Z] 03:32:54     INFO - Entering test bound noNotifications
[task 2019-11-12T03:32:54.487Z] 03:32:54     INFO - Extension loaded
[task 2019-11-12T03:32:54.488Z] 03:32:54     INFO - Console message: 1573529573851	addons.webextension.<unknown>	WARN	Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-12T03:32:54.488Z] 03:32:54     INFO - Buffered messages finished
[task 2019-11-12T03:32:54.489Z] 03:32:54     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js | true == false - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js :: checkExtension :: line 136
[task 2019-11-12T03:32:54.489Z] 03:32:54     INFO - Stack trace:
[task 2019-11-12T03:32:54.489Z] 03:32:54     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js:checkExtension:136
[task 2019-11-12T03:32:54.489Z] 03:32:54     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js:noNotifications:18
[task 2019-11-12T03:32:54.490Z] 03:32:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-11-12T03:32:54.490Z] 03:32:54     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-11-12T03:32:54.490Z] 03:32:54     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:926
[task 2019-11-12T03:32:54.491Z] 03:32:54     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-11-12T03:32:54.491Z] 03:32:54     INFO - GECKO(1175) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-12T03:32:54.492Z] 03:32:54     INFO - GECKO(1175) | [Child 1440, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1799
[task 2019-11-12T03:32:54.492Z] 03:32:54     INFO - Leaving test bound noNotifications
[task 2019-11-12T03:32:54.493Z] 03:32:54     INFO - Entering test bound urlbarView
[task 2019-11-12T03:32:54.549Z] 03:32:54     INFO - Extension loaded
[task 2019-11-12T03:32:54.569Z] 03:32:54     INFO - GECKO(1175) | 1573529574567	addons.webextension.<unknown>	WARN	Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-12T03:32:54.578Z] 03:32:54     INFO - Console message: 1573529574567	addons.webextension.<unknown>	WARN	Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-12T03:32:54.606Z] 03:32:54     INFO - GECKO(1175) | ++DOCSHELL 0x7f522892d800 == 7 [pid = 1230] [id = {72527eac-cde2-4ab0-ad33-49e84a193f4c}]
[task 2019-11-12T03:32:54.607Z] 03:32:54     INFO - GECKO(1175) | ++DOMWINDOW == 33 (0x7f522782e7a0) [pid = 1230] [serial = 40] [outer = (nil)]
[task 2019-11-12T03:32:54.607Z] 03:32:54     INFO - GECKO(1175) | ++DOMWINDOW == 34 (0x7f5228961000) [pid = 1230] [serial = 41] [outer = 0x7f522782e7a0]
[task 2019-11-12T03:32:54.607Z] 03:32:54     INFO - GECKO(1175) | [Parent 1175, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-11-12T03:32:54.622Z] 03:32:54     INFO - GECKO(1175) | [Child 1230, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2700
[task 2019-11-12T03:32:54.622Z] 03:32:54     INFO - GECKO(1175) | ++DOMWINDOW == 35 (0x7f52289f9c00) [pid = 1230] [serial = 42] [outer = 0x7f522782e7a0]
[task 2019-11-12T03:32:54.658Z] 03:32:54     INFO - TEST-PASS | browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js | true == true - 
[task 2019-11-12T03:32:54.674Z] 03:32:54     INFO - Leaving test bound urlbarView
[task 2019-11-12T03:32:54.675Z] 03:32:54     INFO - Entering test bound trackingProtection
[task 2019-11-12T03:32:54.682Z] 03:32:54     INFO - GECKO(1175) | ++DOCSHELL 0x7f6f2d3ea000 == 1 [pid = 1440] [id = {a9f42eb1-c1c6-4a71-8898-517b8dbab353}]
[task 2019-11-12T03:32:54.743Z] 03:32:54     INFO - GECKO(1175) | ++DOMWINDOW == 1 (0x7f6f2c20bf20) [pid = 1440] [serial = 1] [outer = (nil)]
[task 2019-11-12T03:32:54.746Z] 03:32:54     INFO - GECKO(1175) | ++DOMWINDOW == 2 (0x7f6f2c308c00) [pid = 1440] [serial = 2] [outer = 0x7f6f2c20bf20]
[task 2019-11-12T03:32:55.029Z] 03:32:55     INFO - GECKO(1175) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpEqHa09.mozrunner/runtests_leaks_tab_pid1461.log
[task 2019-11-12T03:32:55.051Z] 03:32:55     INFO - GECKO(1175) | [Child 1461, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 729
[task 2019-11-12T03:32:55.071Z] 03:32:55     INFO - GECKO(1175) | ++DOMWINDOW == 3 (0x7f6f2d4ad800) [pid = 1440] [serial = 3] [outer = 0x7f6f2c20bf20]
[task 2019-11-12T03:32:55.180Z] 03:32:55     INFO - GECKO(1175) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-12T03:32:55.316Z] 03:32:55     INFO - GECKO(1175) | [Parent 1175, Main Thread] WARNING: '!mPresContext', file /builds/worker/workspace/build/src/dom/events/UIEvent.cpp, line 136
[task 2019-11-12T03:32:55.317Z] 03:32:55     INFO - GECKO(1175) | [Parent 1175, Main Thread] WARNING: '!mPresContext', file /builds/worker/workspace/build/src/dom/events/UIEvent.cpp, line 150
[task 2019-11-12T03:32:55.400Z] 03:32:55     INFO - GECKO(1175) | [Child 1461, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/workspace/build/src/dom/ipc/ContentChild.cpp, line 1799
[task 2019-11-12T03:32:55.476Z] 03:32:55     INFO - Extension loaded
[task 2019-11-12T03:32:55.512Z] 03:32:55     INFO - GECKO(1175) | 1573529575499	addons.webextension.<unknown>	WARN	Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-12T03:32:55.518Z] 03:32:55     INFO - Console message: 1573529575499	addons.webextension.<unknown>	WARN	Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-12T03:32:55.528Z] 03:32:55     INFO - GECKO(1175) | [Parent 1175, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-11-12T03:32:55.538Z] 03:32:55     INFO - GECKO(1175) | ++DOCSHELL 0x7f5228930800 == 8 [pid = 1230] [id = {9df4b039-d583-472e-86ea-eaa1d0ccbd78}]
[task 2019-11-12T03:32:55.539Z] 03:32:55     INFO - GECKO(1175) | ++DOMWINDOW == 36 (0x7f522782e980) [pid = 1230] [serial = 43] [outer = (nil)]
[task 2019-11-12T03:32:55.540Z] 03:32:55     INFO - GECKO(1175) | ++DOMWINDOW == 37 (0x7f52289f6000) [pid = 1230] [serial = 44] [outer = 0x7f522782e980]
[task 2019-11-12T03:32:55.580Z] 03:32:55     INFO - GECKO(1175) | [Child 1230, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2700
[task 2019-11-12T03:32:55.600Z] 03:32:55     INFO - GECKO(1175) | ++DOMWINDOW == 38 (0x7f522a8ce000) [pid = 1230] [serial = 45] [outer = 0x7f522782e980]
[task 2019-11-12T03:32:55.648Z] 03:32:55     INFO - TEST-PASS | browser/components/urlbar/tests/ext/browser/browser_ext_urlbar_isBrowserShowingNotification.js | true == true - 
[task 2019-11-12T03:32:55.718Z] 03:32:55     INFO - Leaving test bound trackingProtection

It looks like the new test

Flags: needinfo?(adw)

It's a failure in the first task, which expects no notifications to be present. So there's probably some notification present when the test starts. The test shouldn't assume no notifications are present initially.

The screenshot shows an update badge on the app menu, but there isn't actually a panel open: https://firefoxci.taskcluster-artifacts.net/R8r-LzulSc2dB_PVpjqGrQ/0/public/test_info//mozilla-test-fail-screenshot_RLw2Hk.png

I'm guessing it's because we use AppMenuNotifications.activeNotification, and it returns true even if a panel isn't currently open. We should fix this, it's not just a problem or fluke in the test.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 72.2 - Nov 4 - 17
Points: --- → 2
Flags: needinfo?(adw)
Priority: P5 → P1
Blocks: 1568594, 1568595

This also updates each test task to make sure the function returns false after each notification is dismissed.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ace5357440a
browser.experiments.urlbar.isBrowserShowingNotification should not treat app menu badges as notifications. r=mak
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.