Closed Bug 1595691 Opened 6 years ago Closed 6 years ago

Don't set loop header slots when adding the backedge

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Bug 1595691 - Don't clobber the loop header's slots in MBasicBlock::setBackedge if there were no type changes. r?nbp!
47 bytes, text/x-phabricator-request
Details | Review

This is causing some issues for the patch in bug 1595476. We only need to do this when there was a type change and we want to do a loop restart.

Priority: -- → P1
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c07c75c09f7 Don't clobber the loop header's slots in MBasicBlock::setBackedge if there were no type changes. r=nbp

https://hg.mozilla.org/mozilla-central/rev/6c07c75c09f7

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: