1595743 - [Dark Theme] Hover feedback is missing in the autocomplete dropdown

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Video of the issue

Affected versions
Nightly 72.0a1 (2019-11-11)
Beta 71.0b8
Release 70.0.1

Affected platforms
Windows 10
MacOS
Ubuntu 18.04

Steps to reproduce

• Launch Firefox
• Set up available Dark theme or download and use any dark theme
• Go to facebook.com
• Fill in one or two set of credentials and save them
• Reload the site
• Toggle the autocomplete dropdown for the username or password field
• Hover over the listed options

Expected result
While hovering over any of the listed options a hover effect should be displayed,

Actual Result
The hover highlight is not displayed when dark themes are applied

Note
This is also reproducible with High Contrast White theme

Comment 1

[Sam Foster [:sfoster] (he/him)]

:tbabos, could you track down a regression range for this? I'm not sure if this is due to theme changes, or login autocomplete changes.

Comment 2

[Matthew N. [:MattN]]

Maybe :ntim is interested in investigating?

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fa5724780fe76d6ccbbd08d978342a1db6a43d49&tochange=5b15326286d466b5cf4889160cc09b59bdde08fd

Regressed by:
8885e98d44d4a34619e5840b160f48d0b89a1337 Harry Twyford — Bug 1453722 - Improvements to Dark Theme search bar. r=dao

The changing of rule for :root[lwt-popup-brighttext] in browser.css seems to cause the problem.

Comment 4

[Tim Nguyen :ntim]

So what's happening here is that the autocomplete popup is using var(--arrowpanel-dimmed) for the hover state (https://searchfox.org/mozilla-central/rev/cac340f10816707e91c46db6d285f80259420f07/browser/themes/shared/autocomplete.inc.css#32-34), but isn't using var(--arrowpanel-background) for the popup background. It should either use exclusively the var(--arrowpanel-*) variables, or exclusively use system colors, the latter should be easier to do I think.

Comment 5

[Brandon_Davison]

Hey, would it be possible to attempt to take this one on as a first commit?

Comment 6

[Jim Mathies [:jimm]]

Tim, can you offer guidance to Brandon?

Comment 7

[Tim Nguyen :ntim]

Sorry, I don't have time to mentor this, maybe Dão has ?

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Marking this fix-optional to remove it from weekly triage.

Comment 9

[Will]

I already filed this https://bugzilla.mozilla.org/show_bug.cgi?id=1571065

Comment 11

[jscher2000]

By the way, this came up on SUMO today for the built-in Dark theme: https://support.mozilla.org/questions/1295686

The user wasn't able to resolve the problem with add-on themes (that might also be a known issue).

Comment 13

[:severin Rudie]

Attachment: Bug 1595743 - fix dark theme popup hover color;r=MattN

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/762d1972d011
fix dark theme popup hover color;r=MattN

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/762d1972d011

Comment 16

[:severin Rudie]

:aryx, would you mind backing this out (of both central and beta)? It caused a regression, and I'm working on something critical right now and won't have time to fix it in the near future.

Comment 17

[:severin Rudie]

Needinfoing myself to fix + reland.

Comment 18

[Narcis Beleuzu [:NarcisB]]

Backed out as req by severin.

Backout link: https://hg.mozilla.org/integration/autoland/rev/61ed3192760a3aaef282c089c064fc8dd3890125

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/61ed3192760a

Comment 20

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/579ed81b8158

Comment 21

[:severin Rudie]

I'm not going to have a chance to fix this one.

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 24

[Dão Gottwald [:dao]]

I can't reproduce this anymore, pretty sure it got fixed elsewhere.