Closed
Bug 1595776
Opened 4 years ago
Closed 4 years ago
IonBuilder::analyzeNewLoopTypes no longer sets last/earlier correctly
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla72
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | wontfix |
firefox72 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
We now set last
to match it
which is wrong: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/js/src/jit/IonBuilder.cpp#646-647
Assignee | ||
Comment 1•4 years ago
|
||
I can fix this but probably after bug 1595476 to avoid merge conflicts.
Flags: needinfo?(jdemooij)
Comment 2•4 years ago
|
||
Type: task → defect
Assignee | ||
Comment 3•4 years ago
|
||
We were not setting last/earlier correctly.
The patch moves the analysis code for a single bytecode op into a separate
function. This makes it much easier to reason about the code because we can
now use early returns and don't have to worry about the loop structure.
It also uses Maybe<> for last/earlier and adds some comments.
Updated•4 years ago
|
Assignee: nobody → jdemooij
Assignee | ||
Updated•4 years ago
|
Status: NEW → ASSIGNED
Flags: needinfo?(jdemooij)
Updated•4 years ago
|
Keywords: regression
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c0c89b7a859 Simplify IonBuilder::analyzeNewLoopTypes, add some comments and fix a bug. r=tcampbell
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Updated•4 years ago
|
status-firefox71:
--- → wontfix
status-firefox-esr68:
--- → unaffected
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•