Closed Bug 1595776 Opened 4 years ago Closed 4 years ago

IonBuilder::analyzeNewLoopTypes no longer sets last/earlier correctly

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I can fix this but probably after bug 1595476 to avoid merge conflicts.

Flags: needinfo?(jdemooij)

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: task → defect

We were not setting last/earlier correctly.

The patch moves the analysis code for a single bytecode op into a separate
function. This makes it much easier to reason about the code because we can
now use early returns and don't have to worry about the loop structure.

It also uses Maybe<> for last/earlier and adds some comments.

Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Flags: needinfo?(jdemooij)
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c0c89b7a859
Simplify IonBuilder::analyzeNewLoopTypes, add some comments and fix a bug. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: