15958 - [FLOAT][BLOCK] Centering in the vicinity of floats

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Stewart Gilray]

Within a site I maintain we have a frame, with 3 33% wide tables within one
larger table.

This does not work, the tables appear to be mis arranged and in correct sizes.

These tables work fine in Netscape Comm 4.7 and MSIE.

Comment 1

[Mats Palmgren (inactive)]

Attachment: testcase distilled from http://www.fragtastic.com/

Comment 2

[karnaze (gone)]

Attachment: an even simpler example

Comment 3

[karnaze (gone)]

Kipp, I table code was incorrectly allocating the sizes of the nested tables in
attachment #2 [details] [diff] [review]. I fixed that and now it looks like a floater problem.

Comment 4

[kipp]

*** This bug has been marked as a duplicate of 13196 ***

Comment 5

[Christine Hoffman]

Verified dup of #13196

Comment 6

[Christine Hoffman]

This is reopened? Should I clear the 'duplicate' resolution?

Comment 7

[kipp]

I did some analysis on testcase #1. The issue turns out to be how we make tables
center themselves. In particular, what we currently do is to set the side
margins to "auto" and let the normal block margin logic take over.

However, in the presence of floaters this doesn't do the right thing :-(

Comment 8

[kipp]

More data: nav4 applies the centering *after* taking into account the presence
of the floaters....I have no idea if css has anything to say about this, but it
explains the bug in the display rather neatly.

I've added dbaron to see if he has any attitude about how we should behave in
this case (testcase1).

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm not sure how your normal block logic makes things end up the way they do.
Could it have something to do with a bug in float-edge?

Comment 10

[kipp]

float-edge has nothing to do with it. The question is, when something is
centered, what is it centered relative too? Should the floaters impact the
centering? navigator says yes, we say "kind of".

I think nav's interpretation is better given that you may have assymetric
floaters (all on the left, all on the right are easy obvious examples).

Opinions?

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

When a block is centered, it's side margins are made equal.  So what are those
margins relative to?  That's where float-edge comes into it, I think (if
float-edge is going to be anything like what I proposed in
http://lists.w3.org/Archives/Public/www-style/1998Dec/0082.html
http://lists.w3.org/Archives/Public/www-style/1998Dec/0083.html ).

Comment 12

[leger]

Updating to default HTML Tables Assignee...kipp no longer with us :-(

Comment 13

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 14

[buster]

mine! mine mine mine!  all mine!  whoo-hoo!

Comment 15

[Doron Rosenberg (IBM)]

*** Bug 30084 has been marked as a duplicate of this bug. ***

Comment 16

[buster]

the centered table must center itself between the rightmost edge of the left 
floaters, and the leftmost edge of the right floaters.

Comment 17

[buster]

Attachment: much simpler test case, no nested tables

Comment 18

[rickg]

moving all buster m15 bugs to m16.

Comment 19

[buster]

mass-moving all remaining M16 bugs to M17

Comment 20

[Theblueman]

not sure if there multiple tables but this page doesn't look quite right.
http://search.netscape.com/Recreation?cp=nsidircat

Comment 21

[Hixie (not reading bugmail)]

Does this occur with floated DIVs too?

Taking bug to examine it. I'm guessing it only affects TABLE elements, if it
affects normal CSS blocks too then this is a major bug.

Comment 22

[Hixie (not reading bugmail)]

the only remaining problem is with -moz-float-edge and floaters with block 
boxes. The issues mentioned above are all working now.

Comment 23

[Hixie (not reading bugmail)]

Removing qawanted. The -moz-float-edge bugs have been filed. (Search for "-moz-
float-edge" in the summary.)