Closed Bug 1595828 Opened 3 months ago Closed 3 months ago

Fix a few more include guards

Categories

(Core :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

I found a few more of these, by looking at .h files that contain # ifdef.

xpcom/threads/MozPromise.h contains this, but is properly include guarded, so apparently clang-format isn't recognizing #if !defined(MozPromise_h_) as an include guard, though the GCC manual says it is one. I left it alone because changing it to something clang-format recognizes causes a lot of churn.

The files I did change are
dom/bindings/ErrorIPCUtils.h
widget/gtk/WakeLockListener.h
xpcom/base/nsObjCExceptions.h

The formatting change presumably happens because clang-format treats
include guards differently.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.