1595842 - Import settings wizard dynamic triplets onboarding card for chrome switchers

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to invoke File > Import from Another Browser... from Chrome switcher onboarding card and add a new chrome switchers onboarding card inside dynamic triplets

Comment 1

[Punam Dahiya [:pdahiya]]

Import wizard is invoked from

• File Menu using MigrationUtils.showMigrationWizard
  https://searchfox.org/mozilla-central/source/browser/base/content/browser-sets.inc#35

• about:login -> Import
  https://searchfox.org/mozilla-central/source/browser/components/aboutlogins/AboutLoginsParent.jsm#273

ActivityStream used to previously support import settings from new tab (https://github.com/mozilla/activity-stream/issues/2787),
this functionality was reverted with https://github.com/mozilla/activity-stream/pull/4918

Comment 2

[Andrei Oprea [:andreio]]

MigrationUtils.showMigrationWizard was invoked by ManualMigration.jsm from a content dispatched action on the new tab page.

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1595842 - Import settings wizard dynamic triplets onboarding card for chrome switchers

Comment 5

[Punam Dahiya [:pdahiya]]

QA Steps:

1. Create a new firefox profile
2. In about:config, Set pref trailhead.firstrun.branches to 'join-dynamic_chrome'
3. Restart and open a new tab
4. Verify dynamic triplets shown are - Import Settings, Sync and Monitor
5. Click of 'Import Chrome Data' should trigger 'Import from another browser' wizard

Comment 6

[Punam Dahiya [:pdahiya]]

NI Aaron for UI review of added chrome switcher card. As discussed in the patch we should fix image display size together with bug 1598403 as onboardingMessageImage style is shared. Thanks

https://phabricator.services.mozilla.com/D54176#1652272

Comment 7

[Punam Dahiya [:pdahiya]]

Attachment: Screenshots of dynamic triplets with chrome switcher card

Comment 8

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot import bookmarks dynamic triplet card.png

Attaching screenshot updated with UI feedback.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44ec1bb66e7e
Import settings wizard dynamic triplets onboarding card for chrome switchers r=fluent-reviewers,k88hudson,flod

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/44ec1bb66e7e

Comment 11

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the “Import Chrome Data”, “Sign in to Sync”, and “Sign Up for Alerts” cards are displayed when enrolled in the “join-dynamic_chrome” branch. I have also verified that the “Import from another browser” wizard is triggered when you click the “Import Chrome Data” button on latest Firefox Nightly 72.0a1 (Build ID: 20191126093448) on Windows 10 x64, macOS 10.15.1, and Ubuntu Linux 18.04 x64.