1595843 - tc-proxy can return ext.certificate.expiry < now when it gets 500's

Status: NEW

(Taskcluster :: Workers, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

2019-11-12 16:34:44.444260 [ERROR   ] code_review_bot.cli: Static analysis failure (revision=PHID-DIFF-26zmu6ynjyeg5qheaw7b error=TaskclusterAuthFailure('ext.certificate.expiry < now\n\n---\n\n* method:     completeArtifact\n* errorCode:  AuthenticationFailed\n* statusCode: 401\n* time:       2019-11-12T16:34:44.495Z'))
2019-11-12 16:34:45.880340 [INFO    ] code_review_bot.revisions: Updated HarborMaster status (state=<BuildState.Fail: 'fail'>)
Traceback (most recent call last):
  File "/usr/local/bin/code-review-bot", line 11, in <module>
    load_entry_point('code-review-bot==1.0.5', 'console_scripts', 'code-review-bot')()
  File "/usr/local/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.8/site-packages/code_review_bot-1.0.5-py3.8.egg/code_review_bot/cli.py", line 128, in main
    w.run(revision)
  File "/usr/local/lib/python3.8/site-packages/code_review_bot-1.0.5-py3.8.egg/code_review_bot/workflow.py", line 93, in run
    self.publish(revision, issues)
  File "/usr/local/lib/python3.8/site-packages/code_review_bot-1.0.5-py3.8.egg/code_review_bot/workflow.py", line 107, in publish
    patch.publish(self.queue_service)
  File "/usr/local/lib/python3.8/site-packages/code_review_bot-1.0.5-py3.8.egg/code_review_bot/revisions.py", line 59, in publish
    self.url = create_blob_artifact(
  File "/usr/local/lib/python3.8/site-packages/code_review_tools-0.1.0-py3.8.egg/code_review_tools/taskcluster.py", line 183, in create_blob_artifact
    queue_service.completeArtifact(
  File "/usr/local/lib/python3.8/site-packages/taskcluster-21.0.0-py3.8.egg/taskcluster/generated/queue.py", line 450, in completeArtifact
    return self._makeApiCall(self.funcinfo["completeArtifact"], *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/taskcluster-21.0.0-py3.8.egg/taskcluster/client.py", line 271, in _makeApiCall
    response = self._makeHttpRequest(entry['method'], _route, payload)
  File "/usr/local/lib/python3.8/site-packages/taskcluster-21.0.0-py3.8.egg/taskcluster/client.py", line 532, in _makeHttpRequest
    raise exceptions.TaskclusterAuthFailure(
taskcluster.exceptions.TaskclusterAuthFailure: ext.certificate.expiry < now

The proxy automatically retries on 500 errors, which is what was happening here. However, it looks like the credentials expired while it was doing so, leading to this error instead of the 500.