Closed Bug 1595891 Opened 4 months ago Closed 3 months ago

Intermittent IndexError raised in get_test_window

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

As seen in bug 1590604,

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275527894&repo=autoland&lineNumber=20207

[task 2019-11-10T06:08:25.067Z] 06:08:25  WARNING - Traceback (most recent call last):
[task 2019-11-10T06:08:25.069Z] 06:08:25  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 627, in _run
[task 2019-11-10T06:08:25.071Z] 06:08:25  WARNING -     self.result = True, self.func(self.protocol, self.url, self.timeout)
[task 2019-11-10T06:08:25.073Z] 06:08:25  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 735, in do_testharness
[task 2019-11-10T06:08:25.074Z] 06:08:25  WARNING -     timeout=10*self.timeout_multiplier)
[task 2019-11-10T06:08:25.076Z] 06:08:25  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 216, in get_test_window
[task 2019-11-10T06:08:25.077Z] 06:08:25  WARNING -     elif handles[0] == parent and len(handles) > 2:
[task 2019-11-10T06:08:25.079Z] 06:08:25  WARNING - IndexError: list index out of range
[task 2019-11-10T06:08:25.079Z] 06:08:25  WARNING - 
[task 2019-11-10T06:08:25.080Z] 06:08:25     INFO - TEST-UNEXPECTED-ERROR | /xhr/send-entity-body-get-head-async.htm | list index out of range

Change order of conditions to avoid intermittent IndexError when there are no handles.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a89e03dd6b3c
Guard against IndexError in wpt get_test_window(); r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20259 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/20259
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/ctTCmMmtSUiWR6NRJ9Od1g)
Flags: needinfo?(gbrown)
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

(In reply to Web Platform Test Sync Bot (IRC #interop) from comment #4)

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/20259

I see only this error:

==================================== ERRORS ====================================
_______________ ERROR collecting webdriver/webdriver/__init__.py _______________
ImportError while importing test module '/home/test/web-platform-tests/tools/webdriver/webdriver/__init__.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
webdriver/webdriver/__init__.py:3: in <module>
    from client import (
E   ModuleNotFoundError: No module named 'client'

which appears unrelated to my change to wptrunner.

:jgraham - Do I need to do anything here?

Flags: needinfo?(gbrown) → needinfo?(james)

Sorry; this wasn't your fault. I've merged it upstream.

Flags: needinfo?(james)
Upstream PR merged by jgraham
You need to log in before you can comment on or make changes to this bug.