1595931 - Incorrect placement of OnClickData in schema file page_action.json

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Lusito]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

I downloaded the schema file and tried to parse it:
https://hg.mozilla.org/integration/autoland/raw-file/tip/browser/components/extensions/schemas/page_action.json

Actual results:

The type with the id "OnClickData" was listed under the manifest types rather than the pageAction types.

This breaks my current parser and is not easily fixable with my current fixing mechanism.

Expected results:

It should have been listed in the pageAction types. You can see it correctly done in browser_action.json:

https://hg.mozilla.org/integration/autoland/raw-file/tip/browser/components/extensions/schemas/browser_action.json

On a sidenote:
Is there any easy way to submit patches for these files?
Over the past ~2 years I have accumulated a couple of fixes I currently need to apply before I can generate TypeScript definitions for the webextension-polyfill-ts library:
https://github.com/Lusito/webextension-polyfill-ts/blob/develop/fixes.json

I'm guessing, that these fixes could all be brought back to the original schema files. However, the contributing guidelines and especially the requirement to study all the required tools first is a big turnoff, since I don't have the time on my hand to learn all that right now. Maybe I can provide patch files instead?

Comment 1

[Jim Mathies [:jimm]]

(In reply to Lusito from comment #0)

On a sidenote:
Is there any easy way to submit patches for these files?
Over the past ~2 years I have accumulated a couple of fixes I currently need to apply before I can generate TypeScript definitions for the webextension-polyfill-ts library:
https://github.com/Lusito/webextension-polyfill-ts/blob/develop/fixes.json

I'm guessing, that these fixes could all be brought back to the original schema files. However, the contributing guidelines and especially the requirement to study all the required tools first is a big turnoff, since I don't have the time on my hand to learn all that right now. Maybe I can provide patch files instead?

If you don't have the bandwidth for all this, you can post a simple patch file here as an attachment and we'll try to get it landed when we have the time.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1595931 fix page_action onClickedData type schema

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57454152fbfd
fix page_action onClickedData type schema r=rpl

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/57454152fbfd

Comment 5

[Miruna Curtean]

Hello,
Can you please provide some steps so we can manually verify this issue? If no manual testing is needed can you please mark it as "qe-verify- "
thank you

Comment 6

[Lusito]

Thanks for the fix. I can verify this works.

The way I tested this was to use this repository: https://github.com/Lusito/webextension-polyfill-ts/
And running "npm run fetch && npm run validate && npm run generate". Before the fix this would fail on the validate step.