Closed Bug 1595977 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20223 - [html] Include omitted script

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20223 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20223
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[html] Include omitted script

The ReferenceError that's thrown due to the absence of this script can cause some browsers to report unstable results. I'm going to discuss addressing that at the harness level, but this fix is straightforward enough that I thought we should apply it regardless.

There are a handful of other tests that include test.js without template.js, but none of them actually depend on that script.

 $ git grep -l test.js html/syntax/parsing | xargs grep -L template.js
 html/syntax/parsing/html5lib_innerHTML_foreign-fragment.html
 html/syntax/parsing/html5lib_innerHTML_math.html
 html/syntax/parsing/html5lib_innerHTML_tests4.html
 html/syntax/parsing/html5lib_innerHTML_tests6.html
 html/syntax/parsing/html5lib_innerHTML_tests7.html
 html/syntax/parsing/html5lib_innerHTML_tests_innerHTML_1.html
 html/syntax/parsing/html5lib_innerHTML_webkit02.html
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 8 tests and 171 subtests

Firefox

OK : 8
PASS: 167
FAIL: 4

Chrome

OK : 8
PASS: 162
FAIL: 9

Safari

OK : 8
PASS: 162
FAIL: 9

Firefox-only failures

/html/syntax/parsing/html5lib_innerHTML_math.html
html5lib_innerHTML_math.html 4f95d47164955a6b163935fd8ac89ea200767330: Firefox: FAIL
html5lib_innerHTML_math.html fa7d4a31838dbcc16bf73672f2f4486cca185673: Firefox: FAIL
html5lib_innerHTML_math.html d9d2e4c0e926a91f5e704846cdbc855e3cb21949: Firefox: FAIL
html5lib_innerHTML_math.html c04b203803f6b3bec3db65db16854e7e624d13ef: Firefox: FAIL

Gecko CI Results

Ran 8 tests and 171 subtests
OK : 8
PASS : 167
FAIL : 4

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6a1e2cdb4ba
[wpt PR 20223] - [html] Include omitted script, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c6a1e2cdb4ba

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.