Closed Bug 1595989 Opened 1 year ago Closed 1 year ago

Disable popup auto hide not working with the search bar

Categories

(Toolkit :: XUL Widgets, defect, P3)

68 Branch
defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla73
Iteration:
73.2 - Dec 16 - Jan 5
Tracking Status
firefox73 --- fixed

People

(Reporter: tallguyyo, Assigned: standard8)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

web developer tool open up browser toolbox (ctrl + shift + alt + I), accepts connection. turn on "disable popup auto-hide". type anything in search bar to bring up list of results/history/bookmark etc. go back to browser toolbox and the popup/drop down closes itself.

Actual results:

search bar produces search history/results or from bookmark, proceeds to close itself after window focuses switches back to browser toolbox.

Expected results:

results stay open just like rest of all other menu/drop down such as address bar results, menu tool bar etc.

Component: Untriaged → General
Product: Firefox → DevTools

Thanks for filing. Indeed other popups remain on top with that option checked, but the address bar autocomplete popup does not.
Brian: you might know what the structural difference is between that popup and other popups that would explain this bug.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(bgrinstead)
Priority: -- → P3

(In reply to Patrick Brosset <:pbro> from comment #1)

Thanks for filing. Indeed other popups remain on top with that option checked, but the address bar autocomplete popup does not.
Brian: you might know what the structural difference is between that popup and other popups that would explain this bug.

Some popups programmatically close themselves on blur, etc. We made some frontend changes to adapt the <select> popup to handle this in Bug 1584218 for instance: https://searchfox.org/mozilla-central/rev/3483fb259b4edbe4594cfcc3911db97d5441b67d/toolkit/actors/SelectChild.jsm#315.

Component: General → Search
Flags: needinfo?(bgrinstead)
Product: DevTools → Firefox
Summary: browser toolbox - disable popup auto hide not working search bar → Disable popup auto hide not working search bar
Summary: Disable popup auto hide not working search bar → Disable popup auto hide not working with the search bar
Priority: P3 → --
See Also: → 1584218

Looking at the code, this is actually governed by the popup autocomplete controller, so I think we should handle this there.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 72.3 - Nov 18 - Dec 1
Component: Search → XUL Widgets
Priority: -- → P3
Product: Firefox → Toolkit
Points: --- → 1
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e38ba0703f0f
Make autocomplete widgets respect devtools's 'disable popup auto-hide'. r=mak

Backed out changeset e38ba0703f0f for causing a11y failures in autocomplete-input.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/eb68144fa7a37066d35a7941649267c56795c415

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=598800&searchStr=a11y&tochange=eb68144fa7a37066d35a7941649267c56795c415&fromchange=1019f8467d744a1c318a3199955e5c2ee7a08d99

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279296059&repo=autoland&lineNumber=3227

[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/states/test_expandable.xhtml | uncaught exception - ReferenceError: XPCOMUtils is not defined at AutocompleteInput@chrome://global/content/elements/autocomplete-input.js:24:7
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - CustomElementConstructor*@chrome://global/content/elements/autocomplete-input.js:692:18
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - @chrome://global/content/customElements.js:816:31
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - CustomElementCreationCallback*@chrome://global/content/customElements.js:815:22
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - @chrome://global/content/customElements.js:820:3
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - observe@resource://gre/modules/CustomElementsListener.jsm:25:31
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO -
[task 2019-12-03T11:54:49.444Z] 11:54:49 INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1669:24
[task 2019-12-03T11:54:49.445Z] 11:54:49 INFO - OnErrorEventHandlerNonNull*@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1649:1
[task 2019-12-03T11:54:49.445Z] 11:54:49 INFO - GECKO(1125) | JavaScript error: chrome://global/content/elements/autocomplete-input.js, line 24: ReferenceError: XPCOMUtils is not defined

Flags: needinfo?(standard8)

I'll have to have a look at this, we might be able to import XPCOMUtils into those scopes/tests, not sure yet.

Flags: needinfo?(standard8)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:standard8, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(standard8)
Flags: needinfo?(standard8)
Attachment #9111174 - Attachment description: Bug 1595989 - Make autocomplete widgets respect devtools's 'disable popup auto-hide'. r?mak → Bug 1595989 - Make autocomplete widgets respect devtools's 'disable popup auto-hide'.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7f7692887bd
Make autocomplete widgets respect devtools's 'disable popup auto-hide'. r=mak
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Iteration: 72.3 - Nov 18 - Dec 1 → 73.2 - Dec 16 - Jan 5
Points: 1 → 2
QA Whiteboard: [qa-73b-p2]
You need to log in before you can comment on or make changes to this bug.