Closed Bug 1596129 Opened 1 year ago Closed 11 months ago

Make use of more abstract algorithms in IndexedDB code

Categories

(Core :: Storage: IndexedDB, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: sg, Assigned: sg)

Details

Attachments

(21 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Attachment #9108424 - Attachment description: Bug 1596129 - Removed code duplication between HandlePreprocess overloads. r=ttung → Bug 1596129 - Removed code duplication between HandlePreprocess overloads.
Attachment #9108442 - Attachment description: Bug 1596129 - Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess. r=ttung → Bug 1596129 - Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess.
Attachment #9108443 - Attachment description: Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=ttung → Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one.
Attachment #9108444 - Attachment description: Bug 1596129 - Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse. r=ttung → Bug 1596129 - Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse.
Attachment #9108445 - Attachment description: Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=ttung → Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy
Attachment #9108446 - Attachment description: Bug 1596129 - Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames. r=ttung → Bug 1596129 - Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames.
Attachment #9108447 - Attachment description: Bug 1596129 - Make use of std::find_if in IDBDatabase::CreateObjectStore. r=ttung → Bug 1596129 - Make use of std::find_if in IDBDatabase::CreateObjectStore.
Attachment #9108448 - Attachment description: Bug 1596129 - Make use of std::find_if in IDBDatabase::DeleteObjectStore. r=ttung → Bug 1596129 - Make use of std::find_if in IDBDatabase::DeleteObjectStore.
Attachment #9108424 - Attachment description: Bug 1596129 - Removed code duplication between HandlePreprocess overloads. → Bug 1596129 - Removed code duplication between HandlePreprocess overloads. r=ttung
Attachment #9108443 - Attachment description: Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. → Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=ttung
Attachment #9108445 - Attachment description: Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy → Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/870f4e528b3a
Removed code duplication between HandlePreprocess overloads. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/0179eae6a0f2
Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess. r=dom-workers-and-storage-reviewers,ttung
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d62ae69e3252
Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=dom-workers-and-storage-reviewers,ttung,asuth
https://hg.mozilla.org/integration/autoland/rev/4443fe091dbf
Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/577e972f6956
Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=dom-workers-and-storage-reviewers,ttung,asuth
https://hg.mozilla.org/integration/autoland/rev/08f48fdbec41
Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/22e4a5fd9310
Make use of std::find_if in IDBDatabase::CreateObjectStore. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5b7c1ca3e3a4
Make use of std::find_if in IDBDatabase::DeleteObjectStore. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/e6ee464360c8
Use range-based for, std::find_if, std::unique and avoid insert-sort on a nsTArray in IDBDatabase::Transaction. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/a70ff1b7351e
Make use of std::accumulate in IDBObjectStore::AddOrPut. r=dom-workers-and-storage-reviewers,ytausky
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be672ee8d758
Make use of std::find_if in IDBObjectStore::Index. r=dom-workers-and-storage-reviewers,ttung
Status: REOPENED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a68ba8afff2d
Extract CreateSortedDOMStringList function and reuse in IDBObjectStore::IndexNames. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/cce16a8c0a05
Make use of std::find_if in IDBObjectStore::CreateIndex. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/734f8f4de864
Use const where easily possible. r=dom-workers-and-storage-reviewers,ytausky
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f76a7cddbe9
Make use of std::find_if in IDBObjectStore::DeleteIndex. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e530347d88be
Make use of range-based for in IDBObjectStore::NoteDeletion. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a2d13e61e29
Make use of std::find_if in FileManagerInfo::GetFileManager. r=dom-workers-and-storage-reviewers,ttung
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3308abfed32f
Make use of std::find_if in FileManagerInfo::InvalidateAndRemoveFileManager. r=dom-workers-and-storage-reviewers,ttung,janv
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8446332b2038
Make use of std::any_of in IDBObjectStore::CreateIndex. r=dom-workers-and-storage-reviewers,asuth
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/055c4d937c48
Removed redundant assertions after infallible EmplaceBack calls. r=dom-workers-and-storage-reviewers,ytausky
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/498a88fa12b2
Introduce DatabaseNameMatchPredicate function to reduce code duplication. r=dom-workers-and-storage-reviewers,ytausky
You need to log in before you can comment on or make changes to this bug.