1596129 - Make use of more abstract algorithms in IndexedDB code

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P3)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Removed code duplication between HandlePreprocess overloads. r=ttung

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess.

Depends on D52844

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=ttung

Depends on D52858

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse.

Depends on D52859

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=ttung

Depends on D52860

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames.

Depends on D52861

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in IDBDatabase::CreateObjectStore.

Depends on D52862

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in IDBDatabase::DeleteObjectStore.

Depends on D52863

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Use range-based for, std::find_if, std::unique and avoid insert-sort on a nsTArray in IDBDatabase::Transaction. r=ttung

Depends on D52864

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::accumulate in IDBObjectStore::AddOrPut. r=ttung

Depends on D52865

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in IDBObjectStore::Index. r=ttung

Depends on D52866

Comment 12

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Extract CreateSortedDOMStringList function and reuse in IDBObjectStore::IndexNames. r=ttung

Depends on D52867

Comment 13

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in IDBObjectStore::CreateIndex. r=ttung

Depends on D52868

Comment 14

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::any_of in IDBObjectStore::CreateIndex. r=ttung

Depends on D52869

Comment 15

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in IDBObjectStore::DeleteIndex. r=ttung

Depends on D52870

Comment 16

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of range-based for in IDBObjectStore::NoteDeletion. r=ttung

Depends on D52871

Comment 17

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in FileManagerInfo::GetFileManager. r=ttung

Depends on D52872

Comment 18

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Make use of std::find_if in FileManagerInfo::InvalidateAndRemoveFileManager. r=ttung

Depends on D52873

Comment 19

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Introduce DatabaseNameMatchPredicate function to reduce code duplication. r=ttung

Depends on D52874

Comment 20

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Use const where easily possible. r=ttung

Depends on D52875

Comment 21

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1596129 - Removed redundant assertions after infallible EmplaceBack calls. r=#dom-workers-and-storage

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/870f4e528b3a
Removed code duplication between HandlePreprocess overloads. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/0179eae6a0f2
Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess. r=dom-workers-and-storage-reviewers,ttung

Comment 23

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/870f4e528b3a
https://hg.mozilla.org/mozilla-central/rev/0179eae6a0f2

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d62ae69e3252
Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=dom-workers-and-storage-reviewers,ttung,asuth
https://hg.mozilla.org/integration/autoland/rev/4443fe091dbf
Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/577e972f6956
Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=dom-workers-and-storage-reviewers,ttung,asuth
https://hg.mozilla.org/integration/autoland/rev/08f48fdbec41
Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/22e4a5fd9310
Make use of std::find_if in IDBDatabase::CreateObjectStore. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/5b7c1ca3e3a4
Make use of std::find_if in IDBDatabase::DeleteObjectStore. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/e6ee464360c8
Use range-based for, std::find_if, std::unique and avoid insert-sort on a nsTArray in IDBDatabase::Transaction. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/a70ff1b7351e
Make use of std::accumulate in IDBObjectStore::AddOrPut. r=dom-workers-and-storage-reviewers,ytausky

Comment 25

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d62ae69e3252
https://hg.mozilla.org/mozilla-central/rev/4443fe091dbf
https://hg.mozilla.org/mozilla-central/rev/577e972f6956
https://hg.mozilla.org/mozilla-central/rev/08f48fdbec41
https://hg.mozilla.org/mozilla-central/rev/22e4a5fd9310
https://hg.mozilla.org/mozilla-central/rev/5b7c1ca3e3a4
https://hg.mozilla.org/mozilla-central/rev/e6ee464360c8
https://hg.mozilla.org/mozilla-central/rev/a70ff1b7351e

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be672ee8d758
Make use of std::find_if in IDBObjectStore::Index. r=dom-workers-and-storage-reviewers,ttung

Comment 27

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/be672ee8d758

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a68ba8afff2d
Extract CreateSortedDOMStringList function and reuse in IDBObjectStore::IndexNames. r=dom-workers-and-storage-reviewers,ytausky
https://hg.mozilla.org/integration/autoland/rev/cce16a8c0a05
Make use of std::find_if in IDBObjectStore::CreateIndex. r=dom-workers-and-storage-reviewers,ttung

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/734f8f4de864
Use const where easily possible. r=dom-workers-and-storage-reviewers,ytausky

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f76a7cddbe9
Make use of std::find_if in IDBObjectStore::DeleteIndex. r=dom-workers-and-storage-reviewers,ttung

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e530347d88be
Make use of range-based for in IDBObjectStore::NoteDeletion. r=dom-workers-and-storage-reviewers,ttung

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a2d13e61e29
Make use of std::find_if in FileManagerInfo::GetFileManager. r=dom-workers-and-storage-reviewers,ttung

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3308abfed32f
Make use of std::find_if in FileManagerInfo::InvalidateAndRemoveFileManager. r=dom-workers-and-storage-reviewers,ttung,janv

Comment 34

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a68ba8afff2d
https://hg.mozilla.org/mozilla-central/rev/cce16a8c0a05
https://hg.mozilla.org/mozilla-central/rev/734f8f4de864
https://hg.mozilla.org/mozilla-central/rev/2f76a7cddbe9
https://hg.mozilla.org/mozilla-central/rev/e530347d88be
https://hg.mozilla.org/mozilla-central/rev/6a2d13e61e29
https://hg.mozilla.org/mozilla-central/rev/3308abfed32f

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8446332b2038
Make use of std::any_of in IDBObjectStore::CreateIndex. r=dom-workers-and-storage-reviewers,asuth

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/055c4d937c48
Removed redundant assertions after infallible EmplaceBack calls. r=dom-workers-and-storage-reviewers,ytausky

Comment 37

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8446332b2038

Comment 38

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/055c4d937c48

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/498a88fa12b2
Introduce DatabaseNameMatchPredicate function to reduce code duplication. r=dom-workers-and-storage-reviewers,ytausky

Comment 40

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/498a88fa12b2