Closed Bug 1596147 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 20234 - [mediacapture-image] Correct failure reporting

Categories

(Core :: Audio/Video: Recording, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20234 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20234
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[mediacapture-image] Correct failure reporting

Prior to this commit, the test
MediaStreamTrack-getConstraints-fast.html triggered asynchronous
operations in parallel. This represented a race condition because for
each subtest, two operations could trigger completion.

Additionally, the test made assertions asynchronously. Because these
assertions were not "wrapped" in the harness's "step" functions,
assertion failures would not be reported as test failures. Failures
would instead be reported inaccurately as harness errors (though if the
browser under test does not implement the unhandledrejection event,
the failed assertion would not be reported at all).

Schedule each pair of asynchronous operations to happen in series, and
ensure that all failed assertions are accurately reported as test
failures.

Component: web-platform-tests → Audio/Video: Recording
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2aa247d310f
[wpt PR 20234] - [mediacapture-image] Correct failure reporting, a=testonly
https://hg.mozilla.org/integration/autoland/rev/67185919f9c0
[wpt PR 20234] - Update wpt metadata, a=testonly

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 32 subtests

Firefox

OK : 1
PASS: 16
FAIL: 16

Chrome

OK : 1
PASS: 16
FAIL: 16

Safari

OK : 1
PASS: 16
FAIL: 16

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.