Reenable eslint rules within layout/
Categories
(Core :: Layout, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: kenrick95)
References
(Blocks 2 open bugs)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
•
|
||
When we replaced .xul test files with .xhtml in the layout directory (Bug 1595877), we had to add a considerable amount of files and rules to the .eslintrc.js file. These test cases should be updated and the relevant lines could then be removed from the top-level .eslintrc.js file.
Comment 2•4 years ago
|
||
For anyone working on this, see bug 1564555 comment 0 for steps that you'd follow to approach this.
In this case, the rules that we'd like to re-enable (by removing their lines from the layout/**
section of the top-level .eslintrc.js file) are:
mozilla/no-useless-parameters
mozilla/no-useless-removeEventListener
no-shadow
(These rules will presumably be tripped by some JS in some of our tests, and we'll need to fix up those tests to respect the rules in order to reenable them. bug 1564555 comment 0 has help on how to discover/fix the failures.)
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/737f3b0c6b04 Re-enable eslint rules within layout and address eslint failures in testcases r=dholbert
Comment 5•4 years ago
|
||
bugherder |
Description
•