1596176 - WebExtension toolbar icon badges covering up the entire icon

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Molly Howell (she/her) (mostly inactive)]

Attachment: broken_badge.png

Steps to reproduce:

1. Create a new profile or open an existing one, doesn't matter.
2. Install uBlock Origin
3. Go to YouTube, so that uBO has things to block and draws its badge to tell you how many things it blocked.

Expected result:
The badge appears in the corner of the uBO icon.

Actual result:
The badge overlays the entire uBO icon.

I've attached a screenshot (showing the MyQOnly addon, not uBlock Origin as in the STR).

This may be Windows-only, I haven't checked elsewhere.

Mozregression gave me this range, which points to bug 1576946. That's why I used this component, but this may need to be fixed on the WebExtension side, I would not know.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1596176 - Add missing linux and windows rule for badge positioning.

Comment 2

[Tim Nguyen :ntim]

Bug 1576946 added this rule for macOS but forgot to port it to Windows and Linux.

Comment 3

[Andrei Petcu]

Maybe related https://bugzilla.mozilla.org/show_bug.cgi?id=1596214
I added mozregression output also

Comment 5

[Andrei Petcu]

My bug (1596214) is on GNU/Linux (Fedora)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e17aebea6696
Add missing linux and windows rule for badge positioning. r=bgrins

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e17aebea6696

Comment 14

[Tim Nguyen :ntim]

Can someone please confirm this is fixed on Linux and Windows ?

Comment 15

[aventura.viper]

(In reply to Tim Nguyen :ntim from comment #14)

Can someone please confirm this is fixed on Linux and Windows ?

FWIW, appears fixed for me on Windows now.

Comment 16

[Clément Lefèvre]

Verified fixed on both Windows and Linux.

Comment 17

[Tim Nguyen :ntim]

Thanks!