1596177 - Remove support for create-task scopes without priorities

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I love this idea, but I don't think firefox-ci is ready:

dustin@lamport ~/p/ci-configuration (40f0d65) $ grep -r queue:create-task: *.yml | grep -v priority | grep -v ':\(very-low\|low\|highest\):'
grants.yml:  - queue:create-task:built-in/succeed
grants.yml:  - queue:create-task:built-in/fail
grants.yml:  - queue:create-task:dummy-test-provisioner/dummy-test-type
grants.yml:  - queue:create-task:localprovisioner/*
grants.yml:  - queue:create-task:medium:proj-autophone/*
grants.yml:  - queue:create-task:medium:proj-awfy/*
grants.yml:  - queue:create-task:packetnet/*
grants.yml:  - queue:create-task:tc-worker-provisioner/*
grants.yml:  - queue:create-task:test-dummy-provisioner/*
grants.yml:  - queue:create-task:medium:terraform-packet/tc-worker-docker-v1-*
grants.yml:  - queue:create-task:dummy-test-provisioner/dummy-test-type
grants.yml:  - queue:create-task:gecko-t-tc-worker/*
grants.yml:  - queue:create-task:localprovisioner/*
grants.yml:  - queue:create-task:packetnet/*
grants.yml:  - queue:create-task:tc-worker-provisioner/*
grants.yml:  - queue:create-task:test-dummy-provisioner/*
grants.yml:  - queue:create-task:dummy-test-provisioner/dummy-test-type
grants.yml:  - queue:create-task:gecko-t-tc-worker/*
grants.yml:  - queue:create-task:localprovisioner/*
grants.yml:  - queue:create-task:packetnet/*
grants.yml:  - queue:create-task:tc-worker-provisioner/*
grants.yml:  - queue:create-task:test-dummy-provisioner/*
grants.yml:  - queue:create-task:localprovisioner/nss-aarch64
grants.yml:  - queue:create-task:localprovisioner/nss-macos-10-12
grants.yml:  - queue:create-task:localprovisioner/nss-rpi
grants.yml:  - queue:create-task:gecko-1/win*
grants.yml:  - queue:create-task:localprovisioner/nss-aarch64
grants.yml:  - queue:create-task:localprovisioner/nss-macos-10-12
hooks.yml:    - queue:create-task:project-relman/relman-svc-memory
hooks.yml:    - queue:create-task:project-relman/relman-svc-memory
hooks.yml:    - queue:create-task:project-relman/relman-svc-memory
hooks.yml:    - queue:create-task:project-relman/relman-svc-memory
hooks.yml:    - queue:create-task:project-relman/relman-svc
hooks.yml:    - queue:create-task:project-relman/relman-svc
hooks.yml:    - queue:create-task:project-relman/relman-svc
hooks.yml:    - queue:create-task:project-relman/relman-svc

and sadly, neither is community:

(sandbox) dustin@lamport ~/p/community-tc-config [worker-client-role] $ git grep queue:create-task: | grep -v ':\(very-low\|low\|lowest\|highest\):'                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
config/projects.yml:        - queue:create-task:null-provisioner/*
config/projects.yml:        - queue:create-task:proj-taskcluster/ci

(as you might expect, those are for docker-worker)

Tom, if you'd like to pursue this, we can get a bug on file to fix docker-worker's use of createTask to use the newer scopes. But maybe this isn't a great time for this kind of cleanup? We can wontfix, or move to firefox-ci to fix that up when the time is right.

Comment 2

[Tom Prince [:tomprince]]

It appears that at least the the older of the sets of legacy scope (define-task+task-group-id+schedule-task) are unused.

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1596177: Remove obsolete worker pools; r?Callek

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1596177: Remove pre-gcp scriptworker worker pools;

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1596177: Remove app service scriptworker scopes without priorities; r?mtabara

Comment 6

[Tom Prince [:tomprince]]

Attachment: Bug 1596177: Use scopes with explicit priorities for hooks; r=Callek

Comment 7

[Tom Prince [:tomprince]]

I think https://github.com/mozilla/community-tc-config/pull/220 removes the last occurrence of the legacy scopes.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Wow, thank you for that!

If you'd like to remove the support from the queue service, please do -- but I'm also happy to do that if you'd rather not.

Comment 9

[Tom Prince [:tomprince]]

I'm happy to leave this in your hands.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster/pull/2439