1596184 - Remove nsStackFrame

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/search?q=-moz-stack&case=false&regexp=false&path=

Comment 1

[Tim Nguyen :ntim]

Bug 1610597 re-introduced nsStackFrame and display: -moz-stack only for the notificationbox. The underlying issue is bug 1614447. This bug will be used to remove the remaining front-end usage of display: -moz-stack and possibly its platform code.

Comment 2

[Tim Nguyen :ntim]

testcase:

// info long
gHighPriorityNotificationBox.appendNotification(
"heiasdlfmasdljnfvjkxac v ka scvkpnxpkdnx mllkasnckacx l aslvkxkcnxcalm m,x zklsnck;xnz mk;scnlmcx ajladnsfkl acvlma cxklansd flm clma xcKLN SVACLKV LCKXV M KS DCL XLMA XCKASNCKNASVKLNADSKLFNKLADSFNMLCX VLM VCKPN VKXCA NKASDNCJOV LJKDS VKSDNKADSNVKDSNVLKDSNVLKM CXVKL CXLKV LKCXVNKLXZCNVDLKASNFKL CML LKAS CKL XCKLANVKCX  CDSKXMZXLMCNLKXCNVM LK CLKCX KLCVKLNCXVKC XVKL XZCLKMV LMXZCV LMCXZ VLKCXVKCXZ  OKCX VKNXCKNVCKLCXNVKLCXNVLKVCXN LKCX VKLCVNLKMCVX KLVCNKCX VKLCXNVLKCX KCLX VKCXVMNKCXZNVKCLXNVKLCZXNVLKZCXVN KLXCV KXLZNVKLCXNVKLCVXCVX".repeat(4), "verylong", null, 3)

// critical very very long
gHighPriorityNotificationBox.appendNotification(
"heiasdlfmasdljnfvjkxac v ka scvkpnxpkdnx mllkasnckacx l aslvkxkcnxcalm m,x zklsnck;xnz mk;scnlmcx ajladnsfkl acvlma cxklansd flm clma xcKLN SVACLKV LCKXV M KS DCL XLMA XCKASNCKNASVKLNADSKLFNKLADSFNMLCX VLM VCKPN VKXCA NKASDNCJOV LJKDS VKSDNKADSNVKDSNVLKDSNVLKM CXVKL CXLKV LKCXVNKLXZCNVDLKASNFKL CML LKAS CKL XCKLANVKCX  CDSKXMZXLMCNLKXCNVM LK CLKCX KLCVKLNCXVKC XVKL XZCLKMV LMXZCV LMCXZ VLKCXVKCXZ  OKCX VKNXCKNVCKLCXNVKLCXNVLKVCXN LKCX VKLCVNLKMCVX KLVCNKCX VKLCXNVLKCX KCLX VKCXVMNKCXZNVKCLXNVKLCZXNVLKZCXVN KLXCV KXLZNVKLCXNVKLCVXCVX".repeat(12), "verylong", null, 7)

// very critical very long
gHighPriorityNotificationBox.appendNotification(
"heiasdlfmasdljnfvjkxac v ka scvkpnxpkdnx mllkasnckacx l aslvkxkcnxcalm m,x zklsnck;xnz mk;scnlmcx ajladnsfkl acvlma cxklansd flm clma xcKLN SVACLKV LCKXV M KS DCL XLMA XCKASNCKNASVKLNADSKLFNKLADSFNMLCX VLM VCKPN VKXCA NKASDNCJOV LJKDS VKSDNKADSNVKDSNVLKDSNVLKM CXVKL CXLKV LKCXVNKLXZCNVDLKASNFKL CML LKAS CKL XCKLANVKCX  CDSKXMZXLMCNLKXCNVM LK CLKCX KLCVKLNCXVKC XVKL XZCLKMV LMXZCV LMCXZ VLKCXVKCXZ  OKCX VKNXCKNVCKLCXNVKLCXNVLKVCXN LKCX VKLCVNLKMCVX KLVCNKCX VKLCXNVLKCX KCLX VKCXVMNKCXZNVKCLXNVKLCZXNVLKZCXVN KLXCV KXLZNVKLCXNVKLCVXCVX".repeat(8), "verylong", null, 8)

expected behaviour: all notifications are open and the most critical one is topmost (in terms of z-index), all notifications always stretch to the size of the largest one.

Comment 3

[Tim Nguyen :ntim]

Attachment: one attempt to make this work

This is just one out of many attempts to fix this (this is notably the suggested workaround in bug 1614447), but doesn't work. I believe dholbert suggested to make the parent which has a different size a block, but unfortunately we can't do that here, because the notificationbox can be appended anywhere.

Comment 4

[Tim Nguyen :ntim]

I've tried/considered these:

• making all/some children use non-XUL layouts
• height: max-content
• possibly think about not relying on the stack/CSS grid, though that's not really possible here.

I did notice the first solution combined with triggering some kind of XUL reflow with the inspector did intermittently work:

• height is too small
• add -moz-box-orient: vertical on <stack> using the inspector
• height is bigger
• toggle it off using the inspector
• height is still big

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596184 - Get rid of nsStackFrame. r=#layout-reviewers

There are no legacy-stack uses anymore.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba73f7aecc51
Get rid of nsStackFrame. r=layout-reviewers,mats

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ba73f7aecc51