Closed Bug 1596199 Opened 4 years ago Closed 4 years ago

Devirtualize GetBindingParent

Categories

(Core :: XBL, task, P3)

Product:
Core
Component:
XBL
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: Gijs, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1596199 - Devirtualize GetBindingParent. r=bzbarsky
47 bytes, text/x-phabricator-request
Details | Review

I ran across this when debugging. Talking to Emilio, now that it's not used by XBL, it should be possible to improve some of this.

Priority: -- → P3

Will do the first part earlier since it's trivial. Removing shadow DOM usage is harder.

Assignee: nobody → emilio
Summary: Devirtualize GetBindingParent, and audit/remove mBindingParent shadow DOM usage → Devirtualize GetBindingParent
Blocks: 1596209

The amount of XUL elements with non-null binding-parent pointer should be
equivalent to HTML now that XBL is gone.

Shadow DOM already has the extended slots for both the binding parent and
containing shadow root.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8a5f2a349bc
Devirtualize GetBindingParent. r=bzbarsky

https://hg.mozilla.org/mozilla-central/rev/b8a5f2a349bc

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.