[wpt-sync] Sync PR 20244 - [web-locks] Improve test determinism
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 20244 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/20244
Details from upstream follow.
Mike Pennisi <mike@mikepennisi.com> wrote:
[web-locks] Improve test determinism
Two subtests rely on locks which must not be released while the subtest
is running. By providing a Promise that never settles, these tests are
susceptible to interference from locks which have been created in
previous test executions. This is most pronounced when the stability of
the tests is being verified (e.g. during automated patch validation).Configure the test harness to release locks following subtest
completion.
@inexorabletash @pwnall The behavior that this patch guards against may be faulty. The spec currently dictates that an operation to release all locks should be queued "when an agent terminates." It doesn't explain what "terminate" means, but if it includes navigation, then the flakiness which Chromium is exhibiting is evidence of a violation.
In that case, one might argue that this patch is superfluous. I'd still recommend merging it, though, because the current failure is inconsistent (so it blocks work like gh-12267) and difficult to interpret. A new test which is explicitly designed around navigation would be better.
|
Assignee | |
Comment 1•1 year ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e75344ace13999e6e02c1351f0143fe630cd7bfa
|
|
Assignee | |
Comment 2•1 year ago
|
||
GitHub CI Results
wpt.fyi PR Results Base Results
Ran 4 tests and 32 subtests
Firefox
OK : 4
FAIL: 32
Chrome
OK : 4
PASS: 32
Safari
OK : 3
FAIL : 24
ERROR : 1
Gecko CI Results
Ran 4 tests and 32 subtests
OK : 4
FAIL : 32
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5c0a281a9da [wpt PR 20244] - [web-locks] Improve test determinism, a=testonly
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Description
•