1596251 - Intermittent LeakSanitizer | leak at mozilla::detail::UniqueSelector, operator=, mozilla::dom::ClientInfo::ClientInfo, emplace

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=276068681&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SoOnLUWlTrelso0iegzLHQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-11-13T21:23:15.210Z] 21:23:15 INFO - TEST-START | /websockets/remove-own-iframe-during-onerror.window.html
[task 2019-11-13T21:23:15.214Z] 21:23:15 INFO - Closing window 353
[task 2019-11-13T21:23:15.316Z] 21:23:15 INFO - PID 6173 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-11-13T21:23:15.635Z] 21:23:15 INFO - PID 6173 | =================================================================
[task 2019-11-13T21:23:15.635Z] 21:23:15 INFO - PID 6173 | LeakSanitizer: detected memory leaks
[task 2019-11-13T21:23:15.636Z] 21:23:15 INFO - PID 6173 | Indirect leak of 1824 byte(s) in 3 object(s) allocated from:

task 2019-11-13T21:23:21.552Z] 21:23:21 INFO - PID 6173 | Suppressions used:
[task 2019-11-13T21:23:21.552Z] 21:23:21 INFO - PID 6173 | count bytes template
[task 2019-11-13T21:23:21.552Z] 21:23:21 INFO - PID 6173 | 24 728 nsComponentManagerImpl
[task 2019-11-13T21:23:21.553Z] 21:23:21 INFO - PID 6173 | 4 832 mozJSComponentLoader::LoadModule
[task 2019-11-13T21:23:21.553Z] 21:23:21 INFO - PID 6173 | 611 17509 libfontconfig.so
[task 2019-11-13T21:23:21.553Z] 21:23:21 INFO - PID 6173 | 1 29 libglib-2.0.so
[task 2019-11-13T21:23:21.554Z] 21:23:21 INFO - PID 6173 | -----------------------------------------------------
[task 2019-11-13T21:23:21.662Z] 21:23:21 INFO - Browser exited with return code 0
[task 2019-11-13T21:23:21.663Z] 21:23:21 INFO - PROCESS LEAKS None
[task 2019-11-13T21:23:21.663Z] 21:23:21 INFO - ERROR | LeakSanitizer | SUMMARY: AddressSanitizer: 13248 byte(s) leaked in 80 allocation(s).
[task 2019-11-13T21:23:21.664Z] 21:23:21 INFO - LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2019-11-13T21:23:21.664Z] 21:23:21 INFO - This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2019-11-13T21:23:21.665Z] 21:23:21 INFO - Allowed depth was 4
[task 2019-11-13T21:23:21.665Z] 21:23:21 INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::detail::UniqueSelector, operator=, mozilla::dom::ClientInfo::ClientInfo, emplace
[task 2019-11-13T21:23:21.666Z] 21:23:21 INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring
[task 2019-11-13T21:23:21.666Z] 21:23:21 INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2019-11-13T21:23:21.667Z] 21:23:21 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::dom::WebSocket::WebSocket, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor
[task 2019-11-13T21:23:21.667Z] 21:23:21 INFO - INFO | LeakSanitizer | Frame mozilla::dom::WebSocket::WebSocket matched a expected leak

Comment 1

[Razvan Maries]

Started r/b: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Linux%2Cx64%2Casan%2CWeb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-13%2CW%28wpt13%29&tochange=c3630e8d58372c77b6302ea7571082ce124c31b4&fromchange=149d044837d69f645972cc10319baee944cd121b&selectedJob=276362772

Comment 2

[Intermittent Failures Robot]

15 failures in 966 pushes (0.016 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15

Platform breakdown:

• linux64: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-14&endday=2019-11-14&tree=all

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Razvan Maries from comment #1)

Started r/b: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Linux%2Cx64%2Casan%2CWeb%2Cplatform%2Ctests%2Ctest-linux64-asan%2Fopt-web-platform-tests-e10s-13%2CW%28wpt13%29&tochange=c3630e8d58372c77b6302ea7571082ce124c31b4&fromchange=149d044837d69f645972cc10319baee944cd121b&selectedJob=276362772

The bug seems to happen because of this line in the WPT harness
line = 'cors = ' + cors + ' | cookie = ' + cookie.value;

This in turn probably fails because the expected cookie isn't there, but it still shouldn't throw.
It's probably the fact that the test doesn't complete that's keeping WS alive and causing the leak. I'll write up a quick patch and we'll see if that fixes things.

Comment 4

[Intermittent Failures Robot]

29 failures in 914 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 29

Platform breakdown:

• linux64: 29

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-15&endday=2019-11-15&tree=all

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 159625 - Fix exception in cors-tester.py in WPT tests r=jgraham

cookie.value can't be accessed when cookie.first defaults to "no" which causes
it to throw an exception.
This change makes it so we only access cookie.value when the cookie.first
actually returns a cookie.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

(In reply to Stefan Hindli [:stefan_hindli] from bug 159625 comment #7)

https://hg.mozilla.org/mozilla-central/rev/c1e961421fe1

(In reply to Mathew Hodson from bug 159625 comment #8)

It looks like the commit message for this had the wrong bug ID.

(In reply to Web Platform Test Sync Bot (IRC #interop) from bug 159625 comment #5)

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20280 for changes under testing/web-platform/tests

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1596251 - Fix exception in WPT service-workers/cache-storage/resources/vary.py r=jgraham

This exception is unlikely to be the cause of the leak in bug 1596251, but I
came across it while investigating.

Comment 8

[Intermittent Failures Robot]

98 failures in 4207 pushes (0.023 failures/push) were associated with this bug in the last 7 days.

This is the #11 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 96
• mozilla-central: 2

Platform breakdown:

• linux64: 97
• windows7-32-mingwclang: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-11&endday=2019-11-17&tree=all

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82ba763a36a7
Fix exception in WPT service-workers/cache-storage/resources/vary.py r=jgraham

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20302 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/82ba763a36a7

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Intermittent Failures Robot]

32 failures in 987 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 30
• mozilla-central: 1
• try: 1

Platform breakdown:

• linux64: 32

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-18&endday=2019-11-18&tree=all

Comment 15

[Intermittent Failures Robot]

35 failures in 921 pushes (0.038 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 32
• mozilla-inbound: 1
• try: 1
• mozilla-central: 1

Platform breakdown:

• linux64: 35

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-19&endday=2019-11-19&tree=all

Comment 16

[Intermittent Failures Robot]

33 failures in 1050 pushes (0.031 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 30
• mozilla-central: 2
• try: 1

Platform breakdown:

• linux64: 33

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-20&endday=2019-11-20&tree=all

Comment 17

[Intermittent Failures Robot]

17 failures in 964 pushes (0.018 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 16
• mozilla-central: 1

Platform breakdown:

• linux64: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-21&endday=2019-11-21&tree=all

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

jmaher, valentin, i suspect this is still happening. Could you, please, take a look?

Comment 19

[Intermittent Failures Robot]

32 failures in 1098 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 32

Platform breakdown:

• linux64: 32

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-22&endday=2019-11-22&tree=all

Comment 20

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1596251 - Add ClientInfo to the WS leak allowed-list r=jgraham

Comment 21

[Valentin Gosu [:valentin] (he/him)]

Unfortunately I was unable to fix the underlying problem. We have a bunch of resources that leak via websockets. I suspect they aren't being cleaned up properly. We are tracking several other leaks in bug 1582481 - and we'll eventually need to develop a proper fix.
In the mean time the attached patch adds ClientInfo to the allow-list for WPT, which should reduce the orange tint of the trees.

Comment 22

[Intermittent Failures Robot]

165 failures in 5444 pushes (0.03 failures/push) were associated with this bug in the last 7 days.

This is the #3 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 153
• mozilla-central: 8
• try: 3
• mozilla-inbound: 1

Platform breakdown:

• linux64: 165

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-18&endday=2019-11-24&tree=all

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/367f776160cb
Add ClientInfo to the WS leak allowed-list r=jgraham

Comment 24

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/367f776160cb

Comment 25

[Intermittent Failures Robot]

11 failures in 4331 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 9
• mozilla-central: 1
• try: 1

Platform breakdown:

• linux64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-11-25&endday=2019-12-01&tree=all

Comment 26

[Andreea Pavel [:apavel]]

No failures since the 25th of November.

Comment 27

[Intermittent Failures Robot]

7 failures in 5144 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 7

Platform breakdown:

• linux64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-12-02&endday=2019-12-08&tree=all

Comment 28

[Intermittent Failures Robot]

1 failures in 4867 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-12-09&endday=2019-12-15&tree=all

Comment 29

[Intermittent Failures Robot]

1 failures in 4582 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1596251&startday=2019-12-16&endday=2019-12-22&tree=all