1596285 - Make Linux coverage build green again

Status: RESOLVED FIXED

(Testing :: Code Coverage, task)

Description

[Marco Castelluccio [:marco]]

We will soon be using GCC 7 with an opt build.

We can either try to fix the issues with the GCC 7 opt build, or we can try to switch to Clang and directly fix the issues with the Clang build. Since we plan to switch to Clang anyway, it might be a better use of our time.

Comment 1

[Marco Castelluccio [:marco]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=9a1d5f45bf749bdc59ce03bceeed0a166aacd429&selectedJob=275809142.

Most of the failures seem to be related to IndexedDB.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Bug 1596285 - Mark most test suites tier 2 for ccov. r=Aryx

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Bug 1596285 - Skip some consistently failing xpcshell tests. r=Aryx

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/075a66d659d2
Skip some consistently failing xpcshell tests. r=aryx

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Bug 1596285 - Disable some web-platform tests which are timing out with the Linux coverage build. r=whimboo

Comment 6

[Marco Castelluccio [:marco]]

Attachment: Bug 1596285 - Disable some tests which are consistently timing out in the Linux coverage build. r=aryx

Depends on D59316

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/075a66d659d2

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Test which failed the last 3 runs on Linux x64 ccov and have no bug and patch yet:

• browser/components/aboutconfig/test/browser/browser_edit.js and browser/components/aboutconfig/test/browser/browser_observe.js (bc6)
• devtools/client/webconsole/test/browser/browser_toolbox_console_new_process.js (dt5)
• devtools/server/tests/browser/browser_perf-01.js and devtools/server/tests/browser/browser_perf-02.js (dt9)
• browser/base/content/test/static/browser_all_files_referenced.js (dt10)
• devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers.js (dt16)

There are also several tests which fail frequently but not permanently (e.g. dt12) which will also need disabling. Please do a daily review of the failures and disable the ones which fail more than once per day (means at least 2 out of ~4 runs, or >=50% failure rate).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb7e027b119d
Mark most test suites tier 2 for ccov. r=aryx

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fb7e027b119d

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?

Comment 13

[Marco Castelluccio [:marco]]

We can call this fixed as most tests are now green. The remaining failing tests are tracked in separate bugs (blocking this one).