1596323 - Set a thread to directory root, close then reopen debugger fails to show the directory root

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Chujun Lu]

Attachment: reopenDebugger.mp4

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36

Steps to reproduce:

1.Open http://dbg-workers.glitch.me/ and open debugger
2.Right click at "Main Thread" in source panel
3.Click "Set directory root"
4.Close debugger
5.Reopen debugger

Actual results:

Root header shows "thread19".
Message "This page has no sources" displays.

Expected results:

Root header shows "Main Thread".
Its sources are shown.

Comment 1

[Chujun Lu]

When we set a thread to directory root, item.path, which is equal to thread.actor in a thread's case, is used as the project directory root and stored in prefs. When debugger is closed and opened again, thread.actor will be different. But the debugger state is initialized with an old directory root. e.g. directory root is server0.conn0.child1/thread19. Thread is now server0.conn1.child1/thread19. Then we check root against threadActors to get thread.name and sources. It will fail.

To get expected results, a naive thought I had was when initialized source state, if prefs.projectDirectoryRoot is a thread.actor, we bump up connX by 1, that was the only change I saw in thread.actor. This solution sounds error-prone.

I also thought about removing this behavior for threads, meaning when we set a thread to root, we don't store the root in prefs. When we reopen the debugger, it doesn't show a thread as root.

Setting a child directory under a thread to root, and reopen debugger won't cause the same issue, since thread.actor is removed from a child's path, and we only use what's left as root.

Let me know what's your take on this.

Comment 2

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:jlast, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report and detailed analysis!

I can easily reproduce on my machine (Win10, Firefox Nightly) using your STRs.

Honza

Comment 4

[Chujun Lu]

Attachment: Bug 1596323 - Do not store root in prefs when set a thread actor to project root r=jlast

When we set a thread to directory root, item.path, which is equal to thread.actor in a thread's case, is used as the project directory root and stored in prefs. When debugger is closed and opened again, thread.actor will be different. But the debugger state is initialized with an old directory root. For example, directory root is server0.conn0.child1/thread19. Thread is now "server0.conn1.child1/thread19."

Comment 5

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:chujunlu, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Jason, could you please look at the patch, thanks.
Honza

Comment 7

[Jason Laster [:jlast]]

Yep, sorry chujun

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2b4e791acf5
Do not store root in prefs when set a thread actor to project root r=jlast

Comment 9

[Chujun Lu]

Thanks Jason!

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d2b4e791acf5