Closed Bug 1596340 Opened 5 years ago Closed 4 years ago

Don't use conditioned profiles, yet, for Windows/AArch64

Categories

(Testing :: Raptor, defect, P1)

Version 3
defect

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: stephend, Assigned: stephend)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Summary: Fall back to creating on-the-fly profiles, rather than (trying to) using a conditioned profile, for Windows/AArch64

Conditioned profiles aren't yet supported for Windows (10)/AArch64 (bug 1582757).

If we're running on Windows/AArch64, aka win64-aarch64, and --with-conditioned-profile is set (commandline/CI config), instead of using a conditioned profile, we need to fall back to the pre-bug 1537944 behavior of creating the profile on the fly, using mozprofile, in self.profile = create_profile(self.profile_class)[1] in build_browser_profile().

Will address this first in Raptor, then Browsertime.

[0] https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/testing/raptor/raptor/raptor.py#169
[1] https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/testing/condprofile/condprof/util.py#292-303

Priority: -- → P1
Summary: Fall back to creating on-the-fly profiles, rather than using a conditioned profile, for Windows/AArch64 → Don't use conditioned profiles, yet, for Windows/AArch64

Hey Stephen, what is the status of this (these jobs are failing steady currently is that right)? Thanks!

Flags: needinfo?(stephen.donner)

(In reply to Robert Wood [:rwood] from comment #1)

Hey Stephen, what is the status of this (these jobs are failing steady currently is that right)? Thanks!

Sorry, yes - these are still failing [0][1] (and are tier 3, but still!) with the following traceback[2]:
condprof.client.ProfileNotFoundError: 404

Treeherder view of the jobs: https://treeherder.mozilla.org/#/jobs?repo=autoland&tier=1%2C2%2C3&searchStr=aarch%2Ccond&fromchange=aa497f0dabfee41f923665da6c1e60dcece90f44

I definitely could use help with this; I couldn't yet get beyond this temporary hack: https://hg.mozilla.org/try/rev/494975ab151a8144116eb1fb3c6de66f66eb7d49. Until I'm able to figure this out, I wonder if I could land that as a stopgap? It will still pollute Treeherder and Perfherder, so I'm pretty sure the answer is "no."

Will take another, closer look today, since I've now also made headway into Android support[3]

[0] https://treeherder.mozilla.org/#/jobs?repo=autoland&tier=1%2C2%2C3&searchStr=aarch%2Ccond&fromchange=aa497f0dabfee41f923665da6c1e60dcece90f44&selectedJob=278317431
[1] https://treeherder.mozilla.org/#/jobs?repo=autoland&tier=1%2C2%2C3&searchStr=aarch%2Ccond&fromchange=aa497f0dabfee41f923665da6c1e60dcece90f44&selectedJob=278317434
[2] https://gist.github.com/stephendonner/5778edd57348e22b0341007ea7866e6d
[3] https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=783fb655d0f6f7b9e6064edaa09d6fb5b8fa4712

Flags: needinfo?(stephen.donner)
Pushed by sdonner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9e71b4a376b
Don't use conditioned profiles, yet, for Windows/AArch64. r=perftest-reviewers,rwood
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: