1596346 - Set --post-startup-delay to 0, if running under --with-conditioned-profile

Status: RESOLVED FIXED

(Testing :: Raptor, task, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Set --post-startup-delay to 0, if running under --with-conditioned-profile

As part of the original intentions for conditioned-profile usage in both Raptor and Browsertime, we can cut 12.5 minutes per tp6 cold page-load suite, by nixing "browser settle time"[0].

To do so, I propose we key off the set/passed-in with-conditioned-profile commandline arg (from bug 1537944), and then extend/set --post-startup-delay[1][2] to 0.

I've been testing with and without this flag, in conditioned-profile runs locally, for a few weeks, without known issues.

I want to make sure this is done the right way (flexibility) at the right time (carefully, while we're still vetting); thoughts?

--
[0] https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/testing/raptor/raptor/raptor.py#671
[1] https://searchfox.org/mozilla-central/search?q=post_startup_delay&case=false&regexp=false&path=
[2] https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/testing/raptor/raptor/raptor.py#1720

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Need to test:

• Raptor, cold, with conditioned profile: ./mach raptor -t raptor-tp6-1-cold --with-conditioned-profile
• Raptor cold, on-the-fly-created profile: ./mach raptor -t raptor-tp6-1-cold
• Raptor warm, with conditioned profile ./mach raptor -t raptor-tp6-1 --with-conditioned-profile
• Raptor warm, on-the-fly-created profile ./mach raptor -t raptor-tp6-1
• Browsertime, cold, with conditioned profile: ./mach raptor -t raptor-tp6-1-cold --browsertime --with-conditioned-profile
• Browsertime, cold, on-the-fly-created profile: ./mach raptor -t raptor-tp6-1-cold --browsertime
• Browsertime, warm, with conditioned profile: ./mach raptor -t raptor-tp6-1 --browsertime --with-conditioned-profile
• Browsertime, warm, on-the-fly-created profile: ./mach raptor -t raptor-tp6-1 --browsertime

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Pushed to try, here: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=78249d862cdcd8faa923300887114b7dd64a77ab

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1596346 - Set --post-startup-delay to 0, if running under --with-conditioned-profile. r?#perftest

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09bdf1773bfd
Set --post-startup-delay to 0, if running under --with-conditioned-profile. r=perftest-reviewers,rwood

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/09bdf1773bfd